search

yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
56 stars 44 forks source link

Allow dir:///foo to equal dir:/foo (bsc#1207239) #1285

Closed mvidner closed 1 year ago

mvidner commented 1 year ago

Problem

Since Ruby 3.2, URI("dir:///foo").to_s no longer returns "dir:/foo" and it makes tests fail in yast2-packager:

If we route the 3-slash form via C++ zypp::Url, it gets normalized to a single slash, see also https://github.com/openSUSE/libzypp/issues/441

Solution

In the class that wraps zypp::Url, consider those equal

It fixes a comparison in PkgFinishClient#added_by_installer?

Testing

Screenshots

N/A

coveralls commented 1 year ago

Coverage Status

Coverage: 41.731% (+0.003%) from 41.727% when pulling 5e2c1efde4902300dc832e642fd07015237ba789 on ruby32-uri into f735cc865042294b801a4609c30bd8992618181a on master.

yast-bot commented 1 year ago

:heavy_check_mark: Public Jenkins job #397 successfully finished :heavy_check_mark: Created OBS submit request #1065758

yast-bot commented 1 year ago

:heavy_check_mark: Internal Jenkins job #220 successfully finished :heavy_check_mark: Created IBS submit request #289945