Restore Missing DnsServerAPI.pm

shundhammer commented 1 year ago

This is for the SLE-15-SP5 branch.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1208833

Trello

https://trello.com/c/s0A0v2gw/

Problem

Build failure in SLE-15-SP5 for yast2-dns-server and yast2-http-server:

https://build.suse.de/package/live_build_log/Devel:YaST:Head/yast2-dns-server/SUSE_SLE-15-SP5_GA/x86_64

[sh @ balrog] ...yast/yast-dns-server/test 24 % rake test:unit 
(in /work/src/yast/yast-dns-server)
rspec --color --format doc 'test/dns_server_ui_test.rb' 'test/main_test.rb' 'test/service_widget_helpers_test.rb' 'test/dns_server_cmdline_test.rb' 'test/dns_server_test.rb' 'test/etc_named_parsing_test.rb' 'test/masterzone_test.rb'
Traceback (most recent call last):
    20: from /usr/bin/rspec:23:in `<main>'
    19: from /usr/bin/rspec:23:in `load'
    18: from /usr/lib64/ruby/gems/2.5.0/gems/rspec-core-3.5.4/exe/rspec:4:in `<top (required)>'
    17: from /usr/lib64/ruby/gems/2.5.0/gems/rspec-core-3.5.4/lib/rspec/core/runner.rb:45:in `invoke'
    16: from /usr/lib64/ruby/gems/2.5.0/gems/rspec-core-3.5.4/lib/rspec/core/runner.rb:71:in `run'
    15: from /usr/lib64/ruby/gems/2.5.0/gems/rspec-core-3.5.4/lib/rspec/core/runner.rb:86:in `run'
    14: from /usr/lib64/ruby/gems/2.5.0/gems/rspec-core-3.5.4/lib/rspec/core/runner.rb:100:in `setup'
    13: from /usr/lib64/ruby/gems/2.5.0/gems/rspec-core-3.5.4/lib/rspec/core/configuration.rb:1433:in `load_spec_files'
    12: from /usr/lib64/ruby/gems/2.5.0/gems/rspec-core-3.5.4/lib/rspec/core/configuration.rb:1433:in `each'
    11: from /usr/lib64/ruby/gems/2.5.0/gems/rspec-core-3.5.4/lib/rspec/core/configuration.rb:1435:in `block in load_spec_files'
    10: from /usr/lib64/ruby/gems/2.5.0/gems/rspec-core-3.5.4/lib/rspec/core/configuration.rb:1435:in `load'
     9: from /work/src/yast/yast-dns-server/test/dns_server_ui_test.rb:5:in `<top (required)>'
     8: from /usr/lib64/ruby/vendor_ruby/2.5.0/yast/yast.rb:186:in `import'
     7: from /usr/lib64/ruby/vendor_ruby/2.5.0/yast/yast.rb:186:in `import_pure'
     6: from /work/src/yast/yast-dns-server/src/modules/DnsServerUI.rb:14:in `<top (required)>'
     5: from /work/src/yast/yast-dns-server/src/modules/DnsServerUI.rb:110:in `<module:Yast>'
     4: from /work/src/yast/yast-dns-server/src/modules/DnsServerUI.rb:68:in `main'
     3: from /usr/lib64/ruby/vendor_ruby/2.5.0/yast/yast.rb:159:in `include'
     2: from /work/src/yast/yast-dns-server/src/include/dns-server/dialog-main.rb:39:in `initialize_dns_server_dialog_main'
     1: from /usr/lib64/ruby/vendor_ruby/2.5.0/yast/yast.rb:186:in `import'
/usr/lib64/ruby/vendor_ruby/2.5.0/yast/yast.rb:186:in `import_pure': Failed to load Module 'DnsServerUI' due to: component cannot import namespace 'DnsServerAPI' (RuntimeError)
rake aborted!
Command failed with status (1): [rspec --color --format doc 'test/dns_serve...]

Tasks: TOP => test:unit
(See full trace by running task with --trace)

Cause

That file DnsServerAPI.pm was removed in a recent cleanup in yast-yast2.

But that was at a time when changes in YaST:Head were still submitted to both Factory and SLE-15-SP5.

While the change was okay and appropriate for Factory, it broke SLE-15-SP5 where both yast2-dns-server and yast2-http-server were still included and supported (both are dropped in Factory) which both require that module for building.

Fix

Branch off SLE-15-SP5 (done by @lslezak)
Revert the change for SLE-15-SP5 (this PR)

Related PR

PR for master that reverts this revert so we can continue to merge future fixes to SLE-15-SP5 into master:
1288

coveralls commented 1 year ago

Coverage: 41.821%. Remained the same when pulling d14420177e9aa998fe632d502eaafedeb50e0646 on huha-restore-missing into 04bce127e0cf3e6f82e9a01720c79a8d82a2bb2b on SLE-15-SP5.

yast-bot commented 1 year ago

:x: Internal Jenkins job #3 failed

yast-bot commented 1 year ago

:heavy_check_mark: Internal Jenkins job #4 successfully finished :heavy_check_mark: Created IBS submit request #291486

yast / yast-yast2