Fix case-insensitive finding of LICENSE.*.TXT (bsc#1215698)

yast / yast-yast2

YaST module yast2

http://en.opensuse.org/Portal:YaST

GNU General Public License v2.0

54 stars 44 forks source link

Fix case-insensitive finding of LICENSE.*.TXT (bsc#1215698) #1292

Closed mvidner closed 9 months ago

mvidner commented 9 months ago

Problem

"License Agreement" not shown in installer (maybe related to KVM??)

it turns out Ruby 3.1 drops the formerly working FNM_CASEFOLD for Dir.glob but it keeps working for File.fnmatch?

Solution

Implement a globbing method that avoids the dropped feature

Testing

Extended an existing test, checked that it fails/succeeds before/after fix

Screenshots

N/A

mvidner commented 9 months ago

ah, I need to add FNM_EXTGLOB for brace expansion, and add a casematching filename to the test data

coveralls commented 9 months ago

coverage: 41.872% (+0.008%) from 41.864% when pulling e3b678ecf3734810dd58b281edbe5c6186c1834d on broken-casefold into c443e4d77fabffbf743259906eb5e3fae723d266 on master.

mvidner commented 9 months ago

ah, version+changelog missing

mvidner commented 9 months ago

OBS SR: https://build.opensuse.org/request/show/1115986