search

yast / yast-yast2

YaST module yast2
http://en.opensuse.org/Portal:YaST
GNU General Public License v2.0
55 stars 44 forks source link

Allow Host / Domain Names starting with an Underscore [SLE-15-SP6] #1302

Closed shundhammer closed 7 months ago

shundhammer commented 7 months ago

Target Branch

This is the merge PR for SLE-15-SP6 of PR #1301 .

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1219920

Problem

Modern DNS setups require using a leading underscore for hostnames in some situations, e.g. _mydomain.example.com. But that is not possible to enter in the YaST DNS Server module: Underscores are generally rejected.

Fix

Allow a leading underscore for host and domain names. Not just anywhere, just as the leading character.

Since the check is in Hostname.rb which belongs to the yast2 package (repo yast-yast2), this is not in the yast2-dns-server package where it might be expected.

Known Limitation

This allows a leading underscore for all components of a FQDN in all circumstances. Users need to have some expertise to know when that is suitable.

The Error Message

The error message quoted in the bug remains the same; we are not changing it, so not all translations will be broken, resulting in purely English error messages for all international users. The message does not contain anything about the leading underscore. But the message should not appear when this is used correctly.

Screenshot

yast-dns-server

Notice that leading underscores are now allowed, while underscores in other places are not.

Testing

Manual testing with sudo yast2 dns-server after a manual sudo rake install.

Reference

Related PRs

coveralls commented 7 months ago

Coverage Status

coverage: 41.883% (-0.04%) from 41.924% when pulling a56337bccc4c442a100c13768b0ea318646d11e6 on huha-hostname-15-6 into 261c33b8752f3adcd06ed48b5f3fa1442ed32097 on SLE-15-SP6.

yast-bot commented 7 months ago

:heavy_check_mark: Internal Jenkins job #7 successfully finished :heavy_check_mark: Created IBS submit request #322046