Modern DNS setups require using a leading underscore for hostnames in some situations, e.g. _mydomain.example.com. But that is not possible to enter in the YaST DNS Server module: Underscores are generally rejected.
Fix
Allow a leading underscore for host and domain names. Not just anywhere, just as the leading character.
Since the check is in Hostname.rb which belongs to the yast2 package (repo yast-yast2), this is not in the yast2-dns-server package where it might be expected.
Known Limitation
This allows a leading underscore for all components of a FQDN in all circumstances. Users need to have some expertise to know when that is suitable.
The Error Message
The error message quoted in the bug remains the same; we are not changing it, so not all translations will be broken, resulting in purely English error messages for all international users. The message does not contain anything about the leading underscore. But the message should not appear when this is used correctly.
Screenshot
Notice that leading underscores are now allowed, while underscores in other places are not.
Testing
Manual testing with sudo yast2 dns-server after a manual sudo rake install.
coverage: 41.887% (+0.008%) from 41.879%
when pulling 6e292309f35c9b635c0255c84d0e3b84e67da6b5 on huha-hostname-master
into e734000d93f9d9272af3167d87b8b5ce56a422d2 on master.
Target Branch
This is the merge PR for master of PR #1301 / PR #1302.
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1219920
Problem
Modern DNS setups require using a leading underscore for hostnames in some situations, e.g.
_mydomain.example.com
. But that is not possible to enter in the YaST DNS Server module: Underscores are generally rejected.Fix
Allow a leading underscore for host and domain names. Not just anywhere, just as the leading character.
Since the check is in
Hostname.rb
which belongs to the yast2 package (repo yast-yast2), this is not in theyast2-dns-server
package where it might be expected.Known Limitation
This allows a leading underscore for all components of a FQDN in all circumstances. Users need to have some expertise to know when that is suitable.
The Error Message
The error message quoted in the bug remains the same; we are not changing it, so not all translations will be broken, resulting in purely English error messages for all international users. The message does not contain anything about the leading underscore. But the message should not appear when this is used correctly.
Screenshot
Notice that leading underscores are now allowed, while underscores in other places are not.
Testing
Manual testing with
sudo yast2 dns-server
after a manualsudo rake install
.Reference
Related PRs