Closed GoogleCodeExporter closed 8 years ago
Sorry guys. wrong repo url:
http://code.google.com/r/tnapierala-mytracks/
Original comment by t.napierala
on 27 May 2010 at 12:34
Very nice, thanks for doing this! Please enable code reviews for non-members of
your
clone so I can review.
Anyway, my preliminary comments are:
* Remove colors.xml, there's nothing translatable there.
* Remove the non-translatable strings - when a string is not found in a
translated
xml, it falls back to the default xml, meaning we have central control over some
strings like the app name and version string.
* In your next commit, please enter meaningful change descriptions ("first part
of
changes" makes little sense in the context of the main mytracks source, and
when the
change is pulled it comes with the original description)
Original comment by rdama...@google.com
on 28 May 2010 at 7:56
All suggestions applied, changes pushed
Original comment by t.napierala
on 30 May 2010 at 11:21
Looks good to me, pulling.
Original comment by rdama...@google.com
on 2 Jun 2010 at 7:25
Original issue reported on code.google.com by
t.napierala
on 27 May 2010 at 7:19