search

yatil / accessifyhtml5.js

While most browsers work all right with the new semantic elements of HTML5, they don’t add the ARIA accessibility attributes that the specification demands. This small JavaScript adds those attributes to enhance accessibility of web sites.
340 stars 30 forks source link

'undefined' in jQuery version #6

Open yellowled opened 12 years ago

yellowled commented 12 years ago

Line 37 of the jQuery version throws an error (used with jQuery 1.7.1, haven't tested any other jQuery version). Chrome 16 web inspector says:

Uncaught TypeError: Cannot call method 'each' of undefined
AccessifyHTML5
(anonymous function)
f.extend._Deferred.e.resolveWith
e.extend.ready
c.addEventListener.C
yatil commented 12 years ago

Works fine for me: http://yatil.net/

Can you provide a link to me to review, please? Seem to be some interaction with some other JavaScript…

yellowled commented 12 years ago

Silly me, this is probably related to jQuery's noConflict mode in my test setting. I'll report back if it isn't since I can't test right now. Sorry. :-)

yatil commented 12 years ago

Ah, I see. Will fix it in 1.0.1…

yellowled commented 12 years ago

Affirmative, it was related to noConflict mode. Not sure you need to fix this, people working in noConflict mode are usually aware of it. ;-)

yatil commented 12 years ago

Well, I shouldn’t mess around with noConflict mode, so it’s my fault!

WraithKenny commented 12 years ago

Haven't tested, but since the script is short and $ is only called twice, replacing it with jQuery should be an quick n easy fix for this.