yatima1460 / Drill

Search files without indexing, but fast crawling
https://drill.software/
GNU General Public License v2.0
269 stars 21 forks source link

home folder doesn't get added to mountpoints #9

Closed RustyRaptor closed 5 years ago

RustyRaptor commented 5 years ago

Linux distro Kubuntu 18.04 LTS

Runtime type Python

Describe the bug In my case at least, the /home folder is not being searched nor is it showing up in mountpoints.

To Reproduce Steps to reproduce the behavior:

  1. Fix the snap issue
  2. Notice nothing is being searched or indexed.
  3. Notice it's not in mountpoints

Expected behavior should at least search your home folder right?

Screenshots Here is the value of mountpoints when it gets defined.

<class 'list'>: ['/', '/snap/gimp/165', '/snap/core18/782', '/snap/core/6673', '/snap/conjure-up/1046', '/snap/micropad/x1', '/snap/gtk-common-themes/1122', '/snap/core18/941', '/snap/core/6818', '/snap/gtk-common-themes/1269', '/snap/slack/11', '/snap/spotify/35', '/snap/slack/12', '/snap/gtk-common-themes/1198', '/snap/core18/731', '/snap/slack/13', '/snap/gimp/130', '/snap/gimp/113', '/snap/conjure-up/1045', '/snap/conjure-up/1047', '/snap/core/6531', '/snap/micropad/13', '/snap/spotify/34']

Other notes I feel like this is an issue that is happening on case by case basis because of how mountpoints are setup. I believe snap folders are considered mount points actually.

If this is not an issue for you please see if your home directory is a seperate partition. That's probably the reason. On most Ubuntu installs the /home folder is not it's own partition. Ok so maybe when we create the mount points list we should check to see if /home is a mount point and if not we should add it manually.

RustyRaptor commented 5 years ago

I noticed you said that you are going to change it so it uses /proc/mounts to get a list of mounts. I am curious to find out if that fixes the issue. Here is what my mounts file looks like.

sysfs /sys sysfs rw,nosuid,nodev,noexec,relatime 0 0
proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0
udev /dev devtmpfs rw,nosuid,relatime,size=12296444k,nr_inodes=3074111,mode=755 0 0
devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000 0 0
tmpfs /run tmpfs rw,nosuid,noexec,relatime,size=2466460k,mode=755 0 0
/dev/sdb1 / ext4 rw,relatime,errors=remount-ro,data=ordered 0 0
securityfs /sys/kernel/security securityfs rw,nosuid,nodev,noexec,relatime 0 0
tmpfs /dev/shm tmpfs rw,nosuid,nodev 0 0
tmpfs /run/lock tmpfs rw,nosuid,nodev,noexec,relatime,size=5120k 0 0
tmpfs /sys/fs/cgroup tmpfs ro,nosuid,nodev,noexec,mode=755 0 0
cgroup /sys/fs/cgroup/unified cgroup2 rw,nosuid,nodev,noexec,relatime,nsdelegate 0 0
cgroup /sys/fs/cgroup/systemd cgroup rw,nosuid,nodev,noexec,relatime,xattr,name=systemd 0 0
pstore /sys/fs/pstore pstore rw,nosuid,nodev,noexec,relatime 0 0
cgroup /sys/fs/cgroup/cpu,cpuacct cgroup rw,nosuid,nodev,noexec,relatime,cpu,cpuacct 0 0
cgroup /sys/fs/cgroup/rdma cgroup rw,nosuid,nodev,noexec,relatime,rdma 0 0
cgroup /sys/fs/cgroup/hugetlb cgroup rw,nosuid,nodev,noexec,relatime,hugetlb 0 0
cgroup /sys/fs/cgroup/cpuset cgroup rw,nosuid,nodev,noexec,relatime,cpuset 0 0
cgroup /sys/fs/cgroup/blkio cgroup rw,nosuid,nodev,noexec,relatime,blkio 0 0
cgroup /sys/fs/cgroup/perf_event cgroup rw,nosuid,nodev,noexec,relatime,perf_event 0 0
cgroup /sys/fs/cgroup/pids cgroup rw,nosuid,nodev,noexec,relatime,pids 0 0
cgroup /sys/fs/cgroup/devices cgroup rw,nosuid,nodev,noexec,relatime,devices 0 0
cgroup /sys/fs/cgroup/net_cls,net_prio cgroup rw,nosuid,nodev,noexec,relatime,net_cls,net_prio 0 0
cgroup /sys/fs/cgroup/memory cgroup rw,nosuid,nodev,noexec,relatime,memory 0 0
cgroup /sys/fs/cgroup/freezer cgroup rw,nosuid,nodev,noexec,relatime,freezer 0 0
systemd-1 /proc/sys/fs/binfmt_misc autofs rw,relatime,fd=24,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=20833 0 0
debugfs /sys/kernel/debug debugfs rw,relatime 0 0
mqueue /dev/mqueue mqueue rw,relatime 0 0
hugetlbfs /dev/hugepages hugetlbfs rw,relatime,pagesize=2M 0 0
configfs /sys/kernel/config configfs rw,relatime 0 0
fusectl /sys/fs/fuse/connections fusectl rw,relatime 0 0
binfmt_misc /proc/sys/fs/binfmt_misc binfmt_misc rw,relatime 0 0
/dev/loop2 /snap/gimp/165 squashfs ro,nodev,relatime 0 0
/dev/loop16 /snap/core18/782 squashfs ro,nodev,relatime 0 0
/dev/loop8 /snap/core/6673 squashfs ro,nodev,relatime 0 0
/dev/loop6 /snap/conjure-up/1046 squashfs ro,nodev,relatime 0 0
/dev/loop1 /snap/micropad/x1 squashfs ro,nodev,relatime 0 0
/dev/loop12 /snap/gtk-common-themes/1122 squashfs ro,nodev,relatime 0 0
/dev/loop3 /snap/core18/941 squashfs ro,nodev,relatime 0 0
/dev/loop7 /snap/core/6818 squashfs ro,nodev,relatime 0 0
/dev/loop4 /snap/gtk-common-themes/1269 squashfs ro,nodev,relatime 0 0
/dev/loop14 /snap/slack/11 squashfs ro,nodev,relatime 0 0
/dev/loop15 /snap/spotify/35 squashfs ro,nodev,relatime 0 0
/dev/loop13 /snap/slack/12 squashfs ro,nodev,relatime 0 0
/dev/loop9 /snap/gtk-common-themes/1198 squashfs ro,nodev,relatime 0 0
/dev/loop19 /snap/core18/731 squashfs ro,nodev,relatime 0 0
/dev/loop0 /snap/slack/13 squashfs ro,nodev,relatime 0 0
/dev/loop10 /snap/gimp/130 squashfs ro,nodev,relatime 0 0
/dev/loop18 /snap/gimp/113 squashfs ro,nodev,relatime 0 0
/dev/loop5 /snap/conjure-up/1045 squashfs ro,nodev,relatime 0 0
/dev/loop20 /snap/conjure-up/1047 squashfs ro,nodev,relatime 0 0
/dev/loop17 /snap/core/6531 squashfs ro,nodev,relatime 0 0
/dev/loop11 /snap/micropad/13 squashfs ro,nodev,relatime 0 0
/dev/loop21 /snap/spotify/34 squashfs ro,nodev,relatime 0 0
tmpfs /run/user/1000 tmpfs rw,nosuid,nodev,relatime,size=2466456k,mode=700,uid=1000,gid=1000 0 0
jetbrains-toolbox /tmp/.mount_jetbraTeJcH5 fuse.jetbrains-toolbox ro,nosuid,nodev,relatime,user_id=1000,group_id=1000 0 0
/dev/fuse /run/user/1000/doc fuse rw,nosuid,nodev,relatime,user_id=1000,group_id=1000 0 0
tmpfs /run/snapd/ns tmpfs rw,nosuid,noexec,relatime,size=2466460k,mode=755 0 0
nsfs /run/snapd/ns/spotify.mnt nsfs rw 0 0
yatima1460 commented 5 years ago

oh right some distros don't mount /home as a separate partition, will fix this soon

yatima1460 commented 5 years ago

your pull request #8 fixes it