yatisht / usher

Ultrafast Sample Placement on Existing Trees
MIT License
122 stars 41 forks source link

--write-taxodium ouput changes for other pathogens #191

Closed amkram closed 2 years ago

amkram commented 2 years ago

This PR introduces some changes necessary to build a Taxonium tree for M. tuberculosis.

theosanderson commented 2 years ago

Wow -- it's super cool to imagine Taxonium being using for other species!

The x-scale thing is a good Q. Firstly I definitely need to add some X zoom, pan function, it's just been somewhat tricky and never top priority. But I'm not sure if that 100% addresses this. I think one may always need some way of manually specifying either the scale, as here, or else the initial zoom range for the x axis (which comes to sort of the same thing). This is because there can be outliers, so I think someone probably has to design what things look like initially (i.e. deciding what is an outlier and can be cut off). But i guess if you don't think that is the case then you have the option of automatically setting this value based on the tree.