search

yatisht / usher

Ultrafast Sample Placement on Existing Trees
MIT License
121 stars 41 forks source link

Make nodes with changed major allele set available to larch through the callback #255

Closed yceh closed 1 year ago

yceh commented 2 years ago

It only includes nodes on the path from source to destination, excluding source and destination, because during the search phase we assume all moves will split the branch between the destination and the parent of the destination node, creating a new node. I am not sure how to pass this information to larch. (If it creates a zero-length branch, it will be cleaned up at the very end.)

Maybe wait until the larch team confirms it is useful to merge this?

yatisht commented 2 years ago

@matsen @willdumm @ognian- Please see the callback function in this PR to provide fully resolved MAT at the end of each matOptimize iteration. If you find this useful, we're happy to merge it in!

yceh commented 2 years ago

Sorry, this call back is not at the end of the iteration, is for each individual move (not even filtered by profitability). Following issue #252.

yatisht commented 2 years ago

Oh, sorry for the confusion! Perhaps we also need the one I described.