search

yatisht / usher

Ultrafast Sample Placement on Existing Trees
MIT License
122 stars 41 forks source link

Small PR with improved error handling #269

Closed jmcbroome closed 2 years ago

jmcbroome commented 2 years ago

This PR contains the following:

  1. Small changes to the iterators for annotation summary to prevent accidental segfaults with annotation vectors of varying size.
  2. Error handling for an empty or unparseable sample file, addressing https://github.com/yatisht/usher/issues/268
  3. Adjustment to the RoHo table calculation that includes Russ's original adjustment to reduce bias by only considering sibling branches with at least 5 descendant samples for comparison.
  4. An overhaul of how indeterminacy is reported by matUtils introduce, with more informative text output for different kinds of indeterminacy.