yatisht / usher

Ultrafast Sample Placement on Existing Trees
MIT License
120 stars 40 forks source link

Remove or rename "pangoLEARN" lineage column #335

Open corneliusroemer opened 1 year ago

corneliusroemer commented 1 year ago

The web sample results table shows two lineages - in ways that could be confusing to users:

There's a "Pango lineage" column and a "Lineage of neighbor" column.

Closer inspection shows that the "Pango lineage" column is the "Usher" result.

Whereas "Lineage of neighbor" is the "pangoLEARN" result of the nearest neighbour.

It may be worth considering adding "pangoLEARN" to the second column, and Usher to the first. Or removing the pangoLEARN one altogether. It seems to be wrong quite often for XBB, as in this case, where it says BA.2, when it's clearly an XBB.1.

Or maybe I misunderstand this altogether.

image