Closed cro closed 2 years ago
Should be fixed in the latest release.
I'm sorry, I upgraded this morning and am still seeing the same behavior. Anything else I can do to help track this down?
Ah, I misunderstood -- the latest release fixed an issue where the floating window is not displaying its content. This appears to be a different issue -- the floating window position is off.
I'll see if I can repro this.
Btw still get all these square boxes instead of the ascii art?
Yes, even if I switch to a patched font (SauceCodePro Nerd Font Mono
)
Finding fvim is like finding a brick of gold. Can't believe my eyes how impressive it is.
I'm not using lunarvim but also have the problem that floating windows like whichkey are displaced.
Would love to use fvim as main editor.
@tobealive which version are you on?
I may have to try "whichkey" myself.
Hey, great reading from you.
I installed fvim via the fvim-linux-amd64-v0.3.520+g8a6f26b.deb
Problem identified. This plugin properly implements 'anchor to bottom' which I did not implement back then.
@tobealive @cro https://dev.azure.com/v-yadli/fvim/_build/results?buildId=700&view=results
When the build finishes, you can access built artifacts for your platform -- in the "Jobs" section, click the platform, go to the build logs, then there's a "download artifact" in the log. Really accessible (TM).
oh great. the overused term blazingly fast is probably really appropriate here.
Not having the build dependencies installed and time today I 'm exited to check this tomorrow.
kudos! 🙏
@tobealive @cro https://dev.azure.com/v-yadli/fvim/_build/results?buildId=700&view=results
When the build finishes, you can access built artifacts for your platform -- in the "Jobs" section, click the platform, go to the build logs, then there's a "download artifact" in the log. Really accessible (TM).
Oh nice, I didn't quiet understood that yesterday and thought I'll need to build it from source. Didn't come a lot in contact with azure yet. That's very nice. Thank you.
Using a border around that floating windows it gets visible that it gets cut off a little, so the border is missing on the right side. That's not a thing that really bothers me and there are probably more important things for that development phase. Just mentioning it here for a possible backlog.
left: fvim, right: nvim in terminal
Probably another thing that is related to the opened issue and is also visible on the screenshot is the error displaying icons and just showing those boxes.
It's possible to solve this by conditionally assigning other icons to fvim. But there is probably a more elegant solution to this. E.g. the codicons pack have trouble being displayed in fvim.
When you have time, you can try clone the repo and run in debug mode: dotnet run
This will give you extra info on the window layout (like in my screenshot)
And btw, do please try this: https://github.com/yatli/fvim/blob/master/ViewModels/CompletionItemViewModel.fs
(How can I not write it in the README??)
Replace your completion icons with these text characters (yes just text) and they will be shown graphically in FVim.
Check Assets/intellisense
for the icons, and I believe you can even hack them for customization.
Update: see https://github.com/yatli/fvim#custom-pum-icons
Could you copy pasta the lua code snippet for icon configuration? I'd like to paste it in and debug.
For example:
symbol_map = {
Text = "",
Method = "",
Function = "",
Constructor = "",
Field = "ﰠ",
Variable = "",
Class = "ﴯ",
Interface = "",
Module = "",
Property = "ﰠ",
Unit = "塞",
Value = "",
Enum = "",
Keyword = "",
Snippet = "",
Color = "",
File = "",
Reference = "",
Folder = "",
EnumMember = "",
Constant = "",
Struct = "פּ",
Event = "",
Operator = "",
TypeParameter = ""
},
These characters display fine on my side:
wait, it displays fine in comments but not in code?
Nope this comment is a leftover from the icons above.
here the full icons lua can you use it like that?
-- https://github.com/microsoft/vscode/blob/main/src/vs/base/common/codicons.ts
-- go to the above and then enter <c-v>u<unicode> and the symbold should appear
-- or go here and upload the font file: https://mathew-kurian.github.io/CharacterMap/
-- find more here: https://www.nerdfonts.com/cheat-sheet
if vim.fn.has "mac" == 1 then
-- elseif vim.fn.has "mac" == 1 then
return {
kind = {
Text = "",
-- Method = "m",
-- Function = "",
-- Constructor = "",
Method = "",
Function = "",
Constructor = "",
Field = "",
-- Variable = "",
Variable = "",
Class = "",
Interface = "",
-- Module = "",
Module = "",
Property = "",
Unit = "",
Value = "",
Enum = "",
-- Keyword = "",
Keyword = "",
-- Snippet = "",
Snippet = "",
Color = "",
File = "",
Reference = "",
Folder = "",
EnumMember = "",
Constant = "",
Struct = "",
Event = "",
Operator = "",
TypeParameter = "",
},
type = {
Array = "",
Number = "",
String = "",
Boolean = "蘒",
Object = "",
},
documents = {
File = "",
Files = "",
Folder = "",
OpenFolder = "",
},
git = {
Add = "",
Mod = "",
Remove = "",
Ignore = "",
Rename = "",
Diff = "",
Repo = "",
},
ui = {
Lock = "",
Circle = "",
BigCircle = "",
BigUnfilledCircle = "",
Close = "",
NewFile = "",
Search = "",
Lightbulb = "",
Project = "",
Dashboard = "",
History = "",
Comment = "",
Bug = "",
Code = "",
Telescope = "",
Gear = "",
Package = "",
List = "",
SignIn = "",
Check = "",
Fire = "",
Note = "",
BookMark = "",
Pencil = "",
-- ChevronRight = "",
ChevronRight = ">",
Table = "",
Calendar = "",
},
diagnostics = {
Error = "",
Warning = "",
Information = "",
Question = "",
Hint = "",
},
misc = {
Robot = "ﮧ",
Squirrel = "",
Tag = "",
Watch = "",
},
}
elseif(vim.g.fvim_loaded) then
return {
kind = {
Text = " ",
-- Method = "m ",
-- Function = " ",
-- Constructor = " ",
Method = " ",
Function = " ",
Constructor = " ",
Field = " ",
-- Variable = " ",
Variable = " ",
Class = " ",
Interface = " ",
-- Module = " ",
Module = " ",
Property = " ",
Unit = " ",
Value = " ",
Enum = " ",
-- Keyword = " ",
Keyword = " ",
-- Snippet = " ",
Snippet = " ",
Color = " ",
File = " ",
Reference = " ",
Folder = " ",
EnumMember = " ",
Constant = " ",
Struct = " ",
Event = " ",
Operator = " ",
TypeParameter = " ",
},
type = {
Array = " ",
Number = " ",
String = " ",
Boolean = "蘒 ",
Object = " ",
},
documents = {
File = " ",
Files = " ",
Folder = " ",
OpenFolder = " ",
},
git = {
Add = " ",
Mod = " ",
Remove = " ",
Ignore = " ",
Rename = " ",
Diff = " ",
Repo = " ",
},
ui = {
Lock = " ",
Circle = " ",
BigCircle = " ",
BigUnfilledCircle = " ",
Close = " ",
NewFile = " ",
Search = " ",
Lightbulb = " ",
Project = " ",
Dashboard = " ",
History = " ",
Comment = " ",
Bug = " ",
Code = " ",
Telescope = " ",
Gear = " ",
Package = " ",
List = " ",
SignIn = " ",
Check = " ",
Fire = " ",
Note = " ",
BookMark = " ",
Pencil = " ",
-- ChevronRight = " ",
ChevronRight = "> ",
Table = " ",
Calendar = " ",
},
diagnostics = {
Error = " ",
Warning = " ",
Information = " ",
Question = " ",
Hint = " ",
},
misc = {
Robot = "ﮧ ",
Squirrel = " ",
Tag = " ",
Watch = " ",
},
}
else
-- פּ ﯟ 蘒練 some other good icons
return {
kind = {
Text = " ",
Method = " ",
Function = " ",
Constructor = " ",
Field = " ",
Variable = " ",
Class = " ",
Interface = " ",
Module = " ",
Property = " ",
Unit = " ",
Value = " ",
Enum = " ",
Keyword = " ",
Snippet = " ",
Color = " ",
File = " ",
Reference = " ",
Folder = " ",
EnumMember = " ",
Constant = " ",
Struct = " ",
Event = " ",
Operator = " ",
TypeParameter = " ",
Misc = " ",
},
type = {
Array = " ",
Number = " ",
String = " ",
Boolean = " ",
Object = " ",
},
documents = {
File = " ",
Files = " ",
Folder = " ",
OpenFolder = " ",
},
git = {
Add = " ",
Mod = " ",
Remove = " ",
Ignore = " ",
Rename = " ",
Diff = " ",
Repo = " ",
},
ui = {
Lock = " ",
Circle = " ",
BigCircle = " ",
BigUnfilledCircle = " ",
Close = " ",
NewFile = " ",
Search = " ",
Lightbulb = " ",
Project = " ",
Dashboard = " ",
History = " ",
Comment = " ",
Bug = " ",
Code = " ",
Telescope = " ",
Gear = " ",
Package = " ",
List = " ",
SignIn = " ",
Check = " ",
Fire = " ",
Note = " ",
BookMark = " ",
Pencil = " ",
ChevronRight = "",
Table = " ",
Calendar = " ",
},
diagnostics = {
Error = " ",
Warning = " ",
Information = " ",
Question = " ",
Hint = " ",
},
misc = {
Robot = " ",
Squirrel = " ",
Tag = " ",
Watch = " ",
},
}
end
alright got repro:
Are they part of NERD font? I may have to update it.
I'm not 100% sure but I think they are not. Got them from a nvim from scratch series and hadn't had problems with them yet i other scenarios. I think lunarvim is using the same icons though probably that's why the thread starter also having those issues.
That lunarvim logo looks like braille to me.
https://utf8-icons.com/utf-8-character-60051
It displays as a battery icon on my side:
This is clearly the windows 10 power tray icon. Probably not what you want?
(offtopic)
Half an hour ago I checked this page, it displays a "mahjong" block. Now it resolves to the battery icon. How weird...
Okay, EA93 is a part of (0xEA60u, 0xEBEBu) // Codicons
New NERD font.
Hey, sorry the late response.
wanting to start into vacation this evening and having ongoing projects, the office is trying to squeeze out the rest of the energy that is left inside of me.
haha a mahjong block sounds cool to me.
An abc
symbol would be the intended one.
Oh great insight and starting point of a real fix.
gotem.
@tobealive https://dev.azure.com/v-yadli/fvim/_build/results?buildId=706&view=results will be ready to download soon.
Braille display ok.
Version 0.3.528 released. Should've fixed everything related to this thread. Case closed. 😎
I appreciate the look of FVim over neovim-qt, really nice job!
I'm seeing something odd when trying to adopt the LunarVim configs. On startup I appear to get a variable-width font, which isn't a big deal, I can
set guifont
fine. But the LunarVim popups appear to be cut off.On startup:
After
set guifont=Hack:h14
After pressing Space to get the standard popup menu:
Expected result (screenshot from neovim-qt):