yatli / fvim

Cross platform Neovim front-end UI, built with F# + Avalonia
MIT License
1.34k stars 30 forks source link

Disable scroll bar? #229

Open austinthresher opened 2 years ago

austinthresher commented 2 years ago

I've looked around but haven't been able to find a way to disable the scrollbar. Is there an option for this? If not, it would be a welcome addition. It's honestly one of the main annoyances preventing me from using this as my main nvim frontend.

luxus commented 2 years ago

Same here, Fvim looks great with all the remote functionality. but the unthemed scrollbar (it's on the screenshots in the README.md) on linux/macos is really a dealbreaker @yatli any plans to implement it?

yatli commented 2 years ago

E_BUSY

Comment out these: https://github.com/yatli/fvim/blob/b836b56bd0a0a16cf0921afcb468269b3648603b/Views/Grid.xaml.fs#L458-L459

PRs are welcome!

luxus commented 2 years ago

doesn't work. still shows a scrollbar

diff --git a/Views/Grid.xaml.fs b/Views/Grid.xaml.fs
index 77492d5..e368695 100644
--- a/Views/Grid.xaml.fs
+++ b/Views/Grid.xaml.fs
@@ -455,8 +455,8 @@ type Grid() as this =
           m_gadget_brush.Color <- color
           m_gadget_brush.Opacity <- 1.0
           ctx.FillRectangle(m_gadget_brush, Rect(sx, sy, sign_w, sign_h))
-    if not (vm.IsMsg || vm.IsFloat) then
-      drawScrollbar()
+    // if not (vm.IsMsg || vm.IsFloat) then
+    //  drawScrollbar()

     let drawDebug() =
       let txt = Media.FormattedText()
yatli commented 2 years ago

stale binary?

that should be the only entrance to scrollbar drawing routine.

luxus commented 2 years ago

don't think so.. i talk about this scrollbar https://user-images.githubusercontent.com/20684720/159672096-2630cbda-243d-46c3-b8f7-6d0a4743dffe.png

yatli commented 2 years ago

ha I see. you two are talking about different things.