Open BobbyESP opened 7 months ago
The plugins support is almost finished; I have to change some things related to the initPython function and even the FFMpeg and Aria2c modules of the lib, but the YoutbeDL module itself can start to be reviewed.
Sorry for this last commit duplicated message d4a2554.
The changes made:
scope
val from the library (coroutine scope)I hadn't a lot of time to continue on this, but will do. It seems to be more complex than what I thought, because also FFmpeg and Aria2c has to be downloadable, and by how the library is built we need to have some kind of shared code, meaning that I have to create another package with that shared code.
The initPython
function will have to be modified (as well as the other such as the FFmpeg and Aria2c) since the unzip process is already included in the download process. We should probably have to create different functions depending on the flavor
@JunkFood02 Can we talk about how we should handle the libraries downloading? I mean. Should the download function be inside the init
one or something like the already implemented in the app demo?
Seems to be an error at build time because of the app, here is the log.
I think that the targetConfiguration isn't correct since I would say that the target should be "bundled" or "nonbundled" but when using those cases Gradle isn't able to find the library:
implementation project(":library") targetConfiguration("bundledDebugRuntimeElements")
This PR is quite large (4000+ LoC) and hard to review. Could we please split it to smaller and more focused PRs, each addressing a specific topic?
The changes that are necessary for this functionality require all the work put into this PR since it means almost a rewrite of the library. I will still try to adjust the code to reduce the number of lines and changes, but please keep in mind that this proposed separation requires the changes made.
I will start by removing the Jetpack Compose app
The changes that are necessary for this functionality require all the work put into this PR
We can just make a pull request depending on another, which means a pull request could only be merge after all it's dependencies got merged into the target branch. This allows us to gradually applying the changes and review them in smaller chunks, making the process more manageable.
The changes that are necessary for this functionality require all the work put into this PR
We can just make a pull request depending on another, which means a pull request could only be merge after all it's dependencies got merged into the target branch. This allows us to gradually applying the changes and review them in smaller chunks, making the process more manageable.
That's interesting and cool. Can we create those chunks in some way or I have to create different branches with manual changes?
I have to create different branches with manual changes
I'm afraid you'll have to do so by hand since github doesn't support such cool pull requests while gitlab is offering this as a paid feature
You can start with building upon an existing branch. Submit a pull request when you're ready for a new, separate feature and create a new branch based of the current branch for further changes. Just make sure each branch(PR) focus on a single modification or topic for clarity.
Also, when developing on parallel branches simultaneously, avoid modifying the same files. You know what would happen 😈
For example: you can start with the update_library
branch
Hahah okay, thanks for the help! I will do this as it should be done, as you told me. I'll keep this PR open for a while, but when I think the other smaller PRs cover everything done in this one, I'll close it.
Pull Request: Move to Downloadable Plugins
Description
This pull request addresses the following changes:
Changes Made
Benefits
Testing
Additional Notes
Related Issues
248
Please review and provide feedback on the proposed changes.