Update: Clone widget - Githubissues

yavin-dev / framework

A framework for rapidly building production quality analytics applications

https://yavin.dev

MIT License

85 stars 35 forks source link

Update: Clone widget #1638

Closed daniellevinson closed 2 years ago

daniellevinson commented 2 years ago

Description

Clone widget

Proposed Changes

clone widget
scroll to bottom when a new widget is added via add or clone

Screenshots

https://user-images.githubusercontent.com/13946669/170116259-177cfb53-dab6-430c-9d85-f9a0ace75e32.mov

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

daniellevinson commented 2 years ago

Some edge cases that aren't handled

invalid lastWidgetAdded id is not removed

cloning a widget and deleting it does not clear the query param

yeah I didn't handle cases like these since they shouldn't break anything or change the UI behavior but I don't mind adding some checks