search

yavin-dev / framework

A framework for rapidly building production quality analytics applications
https://yavin.dev
MIT License
85 stars 35 forks source link

Fix: Filter model updates correctly on filter-value input #1645

Closed 100starnight closed 2 years ago

100starnight commented 2 years ago

License

This PR fixes the following issue:

  1. add a dimension filter that does not have type ahead
  2. type a value into the filter values box
  3. press run
  4. add another value into the filter values box
  5. observe that you're not prompted to press 'run'
  6. press 'run'
  7. observe that nothing happens

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.