Optimization of class.cpp and its children.

[teoman002]

class.cpp is for croyaplayer.cpp, what character.cpp is for player.cpp, however class.cpp is just a helper class containing no information about the character, which means the character has to be passed to each helper method of hunter.cpp.

This introduced problems with hunter implementation:

• I wanted to give class.cpp a Tick() method, which handles double jumps. Instead I had to write it into croyaplayer.cpp, because class.cpp didn't run the Tick() method properly, neither did hunter. Maybe here I made a mistake in the implementation.
• It is not yet possible, to tell the class.cpp constructor to initialize a character on creation, because a class instance is not created with every new character instance.
• InfC classes had always direct access to its character. In contrast to that, InfCroya has no direct access, it needs pointer. That makes porting a lot harder.

What can be improved?

• class.cpp and its children need direct access to a character holding that specific class.
• The tick() method needs to tickle down from croya-player.cpp to class.cpp to smoker.cpp.
• A smoker instance should only exist when there is a croya-player instance that initializes the smoker.

[yavl]

* It is not yet possible, to tell the class.cpp constructor to initialize a character on creation, because a class instance is not created with every new character instance.

IClass should only be used as a base class thus it cannot contain CCharacter instances.

* InfC classes had always direct access to its character. In contrast to that, InfCroya has no direct access, it needs pointer. That makes porting a lot harder.

In 0.6 infc, each class was defined inside CCharacter in many different places and not only there, which was terrible in my opinion.

* I wanted to give class.cpp a Tick() method, which handles double jumps. Instead I had to write it into croyaplayer.cpp, because class.cpp didn't run the Tick() method properly, neither did hunter. Maybe here I made a mistake in the implementation.

This is how should it be done to "fix" the issue. Create a IClass::Tick(CCharacter* pChr) virtual function that will be called from inside CroyaPlayer::Tick(). I will try make one now.

For some complicated classes I think it will be acceptable to write class features outside of IClass child class (example)

[teoman002]

Thanks for your commit showing me, how the code is intended! :)

[yavl]

todo fix bugs, make code in src/infcroya/* cleaner, document newly added classes in headers (comment out) for future easy contributions/forks