search

yavorsky / riot-brunch

Adds Riot.js support to brunch
14 stars 15 forks source link

Update to latest brunch plugin API. #10

Closed MattCheely closed 8 years ago

MattCheely commented 8 years ago

The brunch plugin API has changed since this plugin was originally created. (see: https://github.com/brunch/brunch/blob/master/docs/plugins.md) Prior to this change, the plugin was breaking on the newest release of brunch (2.6.5).

I also updated the code to use the class construct - mostly a stylistic choice, but it seems to be the common convention for brunch plugins.

MattCheely commented 8 years ago

Hmm... Looks like there's still something of an issue with the dependencies step that I missed in my original testing. I'll look into it and update the PR when I have a fix.

yavorsky commented 8 years ago

@MattCheely :+1:

MattCheely commented 8 years ago

I believe this should be working now. In addition to moving to the new API, I updated the plugin to only try to calculate dependencies when using the 'jade' pre-processor, as progeny was blowing up trying to figure out what to do with my .tag files.

It's probably worth having someone who uses jade try this out and verify the dependencies are still tracked correctly. Perhaps @sntran?

sntran commented 8 years ago

@MattCheely I'll update my project with the new version and let you all know.

wnm commented 8 years ago

any updates on this?