yavski / fab-speed-dial

FAB flinging out actionable menu items using the Speed dial metaphor
Apache License 2.0
477 stars 122 forks source link

Why does FabSpeedDial.MenuListener#onPrepareMenu() passes a NavigationMenu? #83

Open ioxua opened 6 years ago

ioxua commented 6 years ago

I'm not sure why onPrepareMenu() receives a NavigationMenu as parameter. NavigationMenu is an internal android class (just look it's package: android.support.design.internal). It's even annotated with @RestrictTo, I think its pretty clear it is not a class intended to be used outside of internal development. Why not pass a android.view.Menu instead? Is there something I'm missing?

(I really do not intend to sound harsh. I'm still practicing my written english so~)