Closed stetro closed 4 years ago
Nice one! Thanks for the PR.
Just the nullability part is important, I can approve and merge once you update that part.
Travis seems to have some connection problem (again 🙄) but the changes seem fine.
Cool, I also added a Readme comment for a short description.
Merging #104 into master will increase coverage by
0.78%
. The diff coverage is42.85%
.
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 66.47% 67.25% +0.78%
==========================================
Files 30 31 +1
Lines 1053 1069 +16
Branches 91 91
==========================================
+ Hits 700 719 +19
+ Misses 293 292 -1
+ Partials 60 58 -2
Impacted Files | Coverage Δ | |
---|---|---|
...om/yayandroid/locationmanager/LocationManager.java | 76.00% <0.00%> (-2.09%) |
:arrow_down: |
.../locationmanager/helper/logging/DefaultLogger.java | 9.09% <9.09%> (ø) |
|
...om/yayandroid/locationmanager/helper/LogUtils.java | 100.00% <100.00%> (+83.33%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f1cbd82...3fa8acb. Read the comment docs.
I've just released version 2.3.0 - assuming you needed this change :)
Great! Thanks a lot :)
Thanks for this library! Due to debugging issues we would like to use our custom logging when using this library. Usually App developers tend to use something like Timber. Therefore I proposed the following interface between LogUtils and
android.util.Log
to be able to replace theDefaultLogger
with one which logs somewhere else (e.g. Timber), or even filters certain log levels.