Updated to connectionless APIs (fix #105)

[victor-denisenko]

Fix #105

Remove deprecated FusedLocationProviderApi, use FusedLocationProviderClient.

Public API changes:

• Delete fields: GooglePlayServicesConfiguration.java : delete failOnConnectionSuspended, suspendedConnectionRetryCount fields and get/set methods. FailType.java : delete GOOGLE_PLAY_SERVICES_CONNECTION_FAIL field. These fields are unused, new api is connectionless.

Other changes:

• Defaults.java : delete FAIL_ON_CONNECTION_SUSPENDED, SUSPENDED_CONNECTION_RETRY_COUNT
• add some tests
• update README

About deleting public api fields: I don't known, maybe save this fields and mark them as deprecated? @yayaa, what your opinion?

[codecov-commenter]

Codecov Report

Merging #107 into master will increase coverage by 2.25%. The diff coverage is 68.11%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   67.69%   69.94%   +2.25%     
==========================================
  Files          31       31              
  Lines        1074     1028      -46     
  Branches       92       87       -5     
==========================================
- Hits          727      719       -8     
+ Misses        289      254      -35     
+ Partials       58       55       -3     

Impacted Files	Coverage Δ
...ndroid/locationmanager/configuration/Defaults.java	100.00% <ø> (ø)
...tionprovider/GooglePlayServicesLocationSource.java	0.00% <0.00%> (ø)
...onprovider/GooglePlayServicesLocationProvider.java	88.18% <90.19%> (-0.87%)	:arrow_down:
...configuration/GooglePlayServicesConfiguration.java	100.00% <100.00%> (ø)
...ders/locationprovider/DefaultLocationProvider.java	89.47% <0.00%> (+2.25%)	:arrow_up:
...om/yayandroid/locationmanager/LocationManager.java	78.66% <0.00%> (+2.66%)	:arrow_up:
...er/configuration/DefaultProviderConfiguration.java	98.52% <0.00%> (+4.41%)	:arrow_up:
...manager/configuration/PermissionConfiguration.java	100.00% <0.00%> (+13.63%)	:arrow_up:
...r/providers/locationprovider/LocationProvider.java	84.84% <0.00%> (+15.15%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48dd7cd...c3796aa. Read the comment docs.

[yayaa]

Hey @victor-denisenko, thanks a lot for the PR. Specially for taking time to integrating the new API, updating tests and ReadMe. Really appreciated. 🙏

Unfortunately, it contains a lot of different changes. I cannot accept it as is. Would you mind splitting into several PRs as following?

• Deprecating onStatusChanged
• GooglePlayService Dialog cancel / dismiss handling
• Adding leakCanary

• Replacing FusedLocationProviderApi with FusedLocationProviderClient (for this one, I have tried to provide feedback as much as possible already, please keep them in consideration while creating separate PRs.)

• Library version update, I'll take care of this. Since it won't release automatically and I need to do manual operation anyway. (Self note: Cmon dude! Update this release process already.)

[victor-denisenko]

Hi, Thanks for the review, I will try to check code changes additionally and write answers soon. Yes, I agree with splitting changes into several PRs.