search

yayaa / LocationManager

Simplify getting user's location for Android
807 stars 187 forks source link

Rationale dialog content is always collapsed! #25

Closed khaledkhj closed 7 years ago

khaledkhj commented 7 years ago

Any way to expand the content of the rationale dialog? I remember it was showing all the content previously, but now it is not!

untitled

Thank you.

yayaa commented 7 years ago

Never saw this actually, can be a new introduced feature? I'll take a look, maybe the method's itself is also updated then yes, otherwise i'm not sure :)

yayaa commented 7 years ago

Wait, this is just an AlertDialog https://github.com/yayaa/LocationManager/blob/master/library/src/main/java/com/yayandroid/locationmanager/helper/PermissionManager.java#L79 Can you give me more information about how do you get this view? On which device and OS version, please?

khaledkhj commented 7 years ago

Yes sure @yayaa I am just running the sample that you provide with the library, and getting that dialog with collapsed information!

I tested it on Samsung devices, Galaxy Tab A and S4.

yayaa commented 7 years ago

This is really very specific case, and i don't believe this is nothing this library should maintain. Issue might even be related that Samsung devices display customized version of AlertDialog.

Again, it is default AlertDialog usage. Maybe i can try to extract displaying AlertDialog or at least provide a solution to switch dialog creation.

yayaa commented 7 years ago

v2.0.0 is just released, and it is possible to create your own dialog implementation.

khaledkhj commented 7 years ago

That is a great news. Thank you.