search

yayaa / LocationManager

Simplify getting user's location for Android
806 stars 187 forks source link

Biswajit Rout google api client not connected bug fixed #60

Closed BiswajitRout closed 7 years ago

BiswajitRout commented 7 years ago

Hi, as per your instruction I added all the checks in GooglePlayServicesLocationProvider class. Please check and let me know if anything is wrong. Thanks :)

yayaa commented 7 years ago

Please do the followings; 1- Close the other PR 2- Remove your name from PR title 3- Clean up all other changes besides GooglePlayServicesLocationProvider 4- You changed the logic, and now tests are failing, you should update them too. This is why Travis complains. I added error log below;

com.yayandroid.locationmanager.providers.locationprovider.GooglePlayServicesLocationProviderTest > requestLocationUpdateShouldRedirectToSource FAILED
    org.mockito.exceptions.verification.WantedButNotInvoked at GooglePlayServicesLocationProviderTest.java:424
com.yayandroid.locationmanager.providers.locationprovider.GooglePlayServicesLocationProviderTest > onLocationChangedShouldRemoveUpdateLocationWhenKeepTrackingIsNotRequired FAILED
    org.mockito.exceptions.verification.WantedButNotInvoked at GooglePlayServicesLocationProviderTest.java:313
BiswajitRout commented 7 years ago

Hi Yayaa, Thank you for the instruction. I will fix this and create a new pull request.