search

yayaa / LocationManager

Simplify getting user's location for Android
806 stars 187 forks source link

Fix same location update calls #65

Closed yayaa closed 7 years ago

yayaa commented 7 years ago

To retrieve the location for the first time, library requests location update as minTimeInterval 0 and this might cause some multiple calls for onLocationChanged even though it actually doesn't.

This adapts the logic to remove update request once onLocationChanged is called, and re-schedule with required time & distance intervals if only keepTracking required.

Issue: https://github.com/yayaa/LocationManager/issues/64

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7aa9d85). Click here to learn what that means. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage          ?   66.91%           
=========================================
  Files             ?       31           
  Lines             ?     1070           
  Branches          ?       91           
=========================================
  Hits              ?      716           
  Misses            ?      295           
  Partials          ?       59
Impacted Files Coverage Δ
...yandroid/locationmanager/helper/UpdateRequest.java 0% <0%> (ø)
...ders/locationprovider/DefaultLocationProvider.java 87.5% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7aa9d85...4a70818. Read the comment docs.