search

yayaa / LocationManager

Simplify getting user's location for Android
806 stars 187 forks source link

Persisting across configuration changes? #76

Closed rmtheis closed 4 years ago

rmtheis commented 6 years ago

Have you considered adjusting this library so that it persists across configuration changes or is lifecycle-aware?

https://developer.android.com/topic/libraries/architecture/lifecycle.html

yayaa commented 6 years ago

You are right, it should persist 🤔 I will try to look into, but I cannot promise anytime soon for now. Feel free to contribute by create a PR if you want tho :)

yayaa commented 6 years ago

By the way, library is already lifecycle aware as long as you called required methods :) I might consider in future to adapt with Architecture components though 👍

yayaa commented 4 years ago

Considering that library should already persist, I do not consider using arch components as external dependency. I'll close this issue, feel free to re-open if you have any further question or request about it.