search

yayahjb / cbflib

CBFlib repository cloned from SF CBFlib repository as of 1 Dec 15
8 stars 20 forks source link

img_set_pixel appears to be faulty #29

Open ndevenish opened 3 years ago

ndevenish commented 3 years ago

It looks like it's trying to check if the input x, y is out of range, but it actually checks that y is in range:

https://github.com/yayahjb/cbflib/blob/5c31378d597fb1c6c543f3e372ff80042c600a52/src/img.c#L2073-L2078

yayahjb commented 3 years ago

Looks like you have found a bug. Want to write and test the fix and submit a pull request?

On Sat, May 15, 2021 at 3:29 PM Nicholas Devenish @.***> wrote:

It looks like it's trying to check if the input x, y is out of range, but it actually checks that y is in range:

https://github.com/yayahjb/cbflib/blob/5c31378d597fb1c6c543f3e372ff80042c600a52/src/img.c#L2073-L2078

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yayahjb/cbflib/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB6EANUBPBBKDIZ55LQNLTTN3DQJANCNFSM446FVJZA .