yayahjb / cbflib

CBFlib repository cloned from SF CBFlib repository as of 1 Dec 15
8 stars 20 forks source link

cif_img.dic: standardise the "photons per second" unit name and describe the unit in the ITEM_UNITS_LIST loop #40

Closed vaitkus closed 11 months ago

vaitkus commented 2 years ago

Issue was noticed in the cif_img.dic dictionary, version 1.8.5.

The photons per second unit appear a single time in the dictionary in the definition of the _diffrn_radiation.beam_flux data item. The usage of this item has two minor issues:

I can create a relevant PR if the proposed changes are acceptable.

vaitkus commented 11 months ago

The CBF/imgCIF dictionary seems to now have been split into a separate repository [1].

This issue was resolved in the draft dictionary version 1.8.8 located in the aforementioned repository.

[1] https://github.com/yayahjb/cbf_imgcif_dictionary/tree/main