Closed vaitkus closed 11 months ago
The CBF/imgCIF dictionary seems to now have been split into a separate repository [1].
This issue was resolved in the draft dictionary version 1.8.8 located in the aforementioned repository.
[1] https://github.com/yayahjb/cbf_imgcif_dictionary/tree/main
Issue was noticed in the
cif_img.dic
dictionary, version 1.8.5.The
photons per second
unit appear a single time in the dictionary in the definition of the_diffrn_radiation.beam_flux
data item. The usage of this item has two minor issues:photons per second
uses spaces to separate words while all other units from the dictionary use underscores (e.g.degrees_squared
,counts_per_photon
). It would be more consistent to rename it tophotons_per_second
.ITEM_UNITS_LIST
loop (_item_units_list.code
,_item_units_list.detail
) except for thephotons per second
. The missing description should be added.I can create a relevant PR if the proposed changes are acceptable.