search

yayaneath / GeoGrasp

Fast geometry-based method for computing grasping points on 3D point clouds.
BSD 2-Clause "Simplified" License
28 stars 13 forks source link

support for ROS2 #10

Closed addy1997 closed 3 years ago

addy1997 commented 3 years ago

Hi @yayaneath,

Referring to the previous issue (#9), I have changed the code for ROS2. These are some changes. The fork can be found here

  1. cloud_processor.cpp file is changed
  2. CMakeLists.txt
  3. package.xml

I want someone to try and test the build. Can that be done?

yayaneath commented 3 years ago

Hi @addy1997

I can do that but I won't have the time until next week. Let me know if you manage to check the changes in the meantime.

addy1997 commented 3 years ago

Hi @addy1997

I can do that but I won't have the time until next week. Let me know if you manage to check the changes in the meantime.

No problem, If I am able to do it, I will add the documentation and update the readme of my fork. Hope you are okay with that?

yayaneath commented 3 years ago

That's completely ok!

addy1997 commented 3 years ago

@yayaneath, I couldn't manage to test run the changes in Geograsp. My apologies. For now, I will close the issue. The fork remains intact. Thanks