search

yaymukund / grunt-ember-handlebars

Precompile ember templates in grunt using only headless-ember.js and ember.js
MIT License
34 stars 26 forks source link

Which version of Handlebars is used? #26

Open jiangty-addepar opened 10 years ago

jiangty-addepar commented 10 years ago

In ember-template-compiler.js, there are the lines

Ember.assert("Ember Handlebars requires Handlebars version 1.0 or 1.1. Include " +
             "a SCRIPT tag in the HTML HEAD linking to the Handlebars file " +
             "before you link to Ember.", Handlebars);

but recent commits have clearly updated Handlebars to 1.3.0.

I'm confused because when I tried to update grunt-ember-handlebars to 0.8.0, I got the error 

Uncaught Error: Could not find module handlebars

thrown by the require('handlebars') line in ember-template-compiler.js:

var Handlebars = (Ember.imports && Ember.imports.Handlebars) || (this && this.Handlebars);
if (!Handlebars && typeof require === 'function') {
  Handlebars = require('handlebars');
}

For all I know it could be something else causing this problem, but I think the docs should at least be consistent with the code!

jiangty-addepar commented 10 years ago

Update: I don't think this package is at fault for the error (I reset to old versions of ember / handlebars and just tried upgrading this package alone, and it seems fine.) Still, the docs should probably be changed?