yazi-rs / yazi-rs.github.io

Documentation site for Yazi.
https://yazi-rs.github.io
MIT License
19 stars 68 forks source link

No status bar config snippit is not 3.x.x compatible #115

Closed GNOMES closed 1 month ago

GNOMES commented 1 month ago

The snippit on Yazi tips for no Status Bar is not working with 3.x.x: https://yazi-rs.github.io/docs/tips#no-status-bar

lpnh commented 1 month ago

Good catch! The Manager has been removed in Yazi 0.3.

I'm not sure how this should be implemented now. A quick fix would be to just remove it, keeping the first line.

function Status:render() return {} end

- local old_manager_render = Manager.render
- function Manager:render(area)
-   return old_manager_render(self, ui.Rect { x = area.x, y = area.y, w = area.w, h = area.h + 1 })
- end
sxyazi commented 1 month ago

Fixed in https://github.com/yazi-rs/yazi-rs.github.io/commit/a53e13399994738afede4cfa2cd3d65c5cea6aee#diff-616e072c90db649f724e9960e86d27fd3274d5bc2a1a2e81a08e97c7dbe0f647, thanks for reporting

github-actions[bot] commented 3 weeks ago

I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.