search

yazi-rs / yazi-rs.github.io

Documentation site for Yazi.
https://yazi-rs.github.io
MIT License
25 stars 87 forks source link

docs: add `mpv` as optional dependency #122

Closed lpnh closed 3 months ago

lpnh commented 3 months ago

Closes #121

I've confirmed its availability at https://mpv.io/installation/

sxyazi commented 3 months ago

Thanks for the PR! I feel like adding MPV to the dependency list is a bit overkill.

The default opener rules are just examples, and users need to customize them based on their needs. Since even VSCode is included, it's impossible for us to add all of them.

lpnh commented 3 months ago

Makes perfect sense. The fact that nobody has complained about it so far (as far as I know) also points in this direction. What I can say is that an audio/video player is less likely to be already installed compared to something like a text editor. However, I understand that including mpv in the optional dependencies might seem somewhat opinionated. Should I close this?

sxyazi commented 3 months ago

Yep let's close this