yb85 / scantailor-advanced-osx

Homebrew formula and App bundler for Scantailor (Advanced)
150 stars 6 forks source link

New Build Error on Ventura #18

Open rostam2000 opened 2 years ago

rostam2000 commented 2 years ago

Whilst trying to use the automated script for both stable and HEAD, the following (new) error appears

==> Setting versioning tag to #release@1.0.18 (build 20221107) ==> cmake .. ==> make Last 15 lines from /Users/siavush/Library/Logs/Homebrew/scantailor/02.make: ^ In file included from /tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/core/filters/output/Settings.cpp:6: /tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/core/filters/output/../../Utils.h:97:35: error: expected ')' for (QObject child : object->children()) { ^ /tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/core/filters/output/../../Utils.h:97:9: note: to match this '(' for (QObject child : object->children()) { ^ [ 37%] Building CXX object src/core/filters/output/CMakeFiles/output.dir/OutputFileParams.cpp.o cd /tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/build/src/core/filters/output && /opt/homebrew/Library/Homebrew/shims/mac/super/clang++ -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DBOOST_TEST_DYN_LINK -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGLWIDGETS_LIB -DQT_OPENGL_LIB -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/build/src/core/filters/output/output_autogen/include -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/build -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/core -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/imageproc -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/foundation -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/math -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/core/zones -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/core/interaction -I/tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/dewarping -isystem /opt/homebrew/lib/QtCore.framework/Headers -iframework /opt/homebrew/lib -isystem /opt/homebrew/share/qt/mkspecs/macx-clang -isystem /opt/homebrew/lib/QtGui.framework/Headers -isystem /opt/homebrew/lib/QtWidgets.framework/Headers -isystem /opt/homebrew/lib/QtXml.framework/Headers -isystem /opt/homebrew/lib/QtNetwork.framework/Headers -isystem /opt/homebrew/lib/QtOpenGL.framework/Headers -isystem /opt/homebrew/lib/QtSvg.framework/Headers -isystem /opt/homebrew/lib/QtOpenGLWidgets.framework/Headers -O3 -DNDEBUG -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -fPIC -std=gnu++17 -MD -MT src/core/filters/output/CMakeFiles/output.dir/OutputFileParams.cpp.o -MF CMakeFiles/output.dir/OutputFileParams.cpp.o.d -o CMakeFiles/output.dir/OutputFileParams.cpp.o -c /tmp/scantailor-20221107-55896-6wwxub/scantailor-advanced-1.0.18/src/core/filters/output/OutputFileParams.cpp 2 errors generated. make[2]: [src/core/filters/output/CMakeFiles/output.dir/Settings.cpp.o] Error 1 make[2]: Waiting for unfinished jobs.... make[1]: [src/core/filters/output/CMakeFiles/output.dir/all] Error 2 make: [all] Error 2

Do not report this issue to Homebrew/brew or Homebrew/core!

yb85 commented 2 years ago

ROLLBACK TO 6.3 IS NOT NEEDED ANYMORE, SEE NEXT MESSAGE

This seems to be caused by the upgrade to qt 6.4, it needs to be reported to the scantailor-advanced repo

A temporary fix, is to install qt 6.3.2, since the brew package does not include 6.x versioning the solution is hacky :

cd "$(brew --repo homebrew/core)" && git checkout ca8fa620c826e4810b9755aa1d2e404a705cf953
HOMEBREW_NO_AUTO_UPDATE=1 brew install qt 

then run the install as usual, and verify your qt version is 6.3.2 and not 6.4

yb85 commented 2 years ago

I (temporarily) patched the formula to fix the missing import of QObject.h in QT 6.4. The install should work properly now.

Please give feedback if it solves the issue so that i can close the ticket

rostam2000 commented 2 years ago

Many thanks, this builds successfully now.