ybakos / flextime-1

A flex period scheduling system for middle schools.
0 stars 0 forks source link

activities#show: Display current flextime teacher #122

Open ybakos opened 4 years ago

ybakos commented 4 years ago

In the activities view we show registration attributes. One of those attributes is the teacher associated with the registration. This association exists to ensure that there is a teacher associated with the registration, in the future event that the flextime teacher changes (See 547039c8ec18bd38770d6c0b0883ca5a7e70d9f5).

However, there is a case where flex time teachers change and we want to see the current flextime teacher for a student, not the one that was associated with the student at the time of registration.

Screen Shot 2019-12-02 at 1 09 48 PM

Here's the story.

Screen Shot 2019-12-02 at 1 41 03 PM

FooTime is using home room teachers. But they are switching to 1st period teachers. To force students to change their teachers, they are going to clear the teacher rosters. This keeps the existing registrations intact, yay. But, the problem is that the activities#show view lists the registration's teacher, which would then be out of "sync" with the current student's 1st period teacher.

This might confuse staff.

Suggested solution: Display the existing teacher in the list, or, if none exists, show the registration teacher.

ybakos commented 4 years ago

I'm no longer sure about whether showing the existing v registration teacher is the best solution. It may be better to just show a blank.

I'm going to put this feature on hold until it arises again.

My concern is that there's tension between the old presumption that it's nice to go back in time and see student rosters w/ registration teachers, even though in the present the student may no longer be active/enrolled or have a current teacher.

We have been tracking the registration.teacher for historical purposes.