ybalt / ansible-tower

Ansible Tower dockerized
Apache License 2.0
104 stars 79 forks source link

Updated to support Ansible Tower 3.1.3 #8

Closed amittell closed 7 years ago

amittell commented 7 years ago

Added new image to DockerHub = lardos/ansibletower

nicoecheza commented 7 years ago

I just did this same thing on Monday.

Just tried your image, and it won't work since you are still executing the apache thing on the docker-entrypoint.sh file.

nicoecheza commented 7 years ago

Also, after commenting the line I pointed out, I've got this error message:


TASK [Gathering Facts] *********************************************************
fatal: [localhost]: UNREACHABLE! => {"changed": false, "msg": "[Errno None] Unable to connect to port 22 on 127.0.0.1 or ::1", "unreachable": true}
    to retry, use: --limit @/opt/tower-setup/install.retry```
amittell commented 7 years ago

The docker-entrypoint.sh file worked without modification for my build, check out the lardos/ansibletower image on DockerHub.

The localhost unreachable error from the tower install playbook is fixed by line 2 in the inventory file in the pull request. Did you use that modified inventory file for your docker build?

nicoecheza commented 7 years ago

I will try it again copying the inventory file since I think I messed up copying it from my own repo.

About the docker-entrypoint.sh, having an Apache config replacement doesn't make any sense since Ansible v3.1 doesn't use Apache anymore, it replaced it with nginx

amittell commented 7 years ago

Ok thanks for the info, those lines are redundant then, but they don't make the build fail so I never paid much attention to the entry point shell script. maybe worth commenting them out just for completeness.

amittell commented 7 years ago

@nicoecheza Updated the docker-entrypoint.sh based on your comments.

Removed tower_setup_conf.yml as duplicate to definitions in inventory file.

Changed version to 3.1.3 and cleaned up unnecessary packages from Dockerfile, rationalized, and updated README.

New Ansible Tower 3.1.3 image available at https://hub.docker.com/r/lardos/ansible-tower/

nicoecheza commented 7 years ago

Nice work @amittell 👍