search

yboetz / motd

Collection of 'message of the day' scripts
889 stars 105 forks source link

Use `zgrep` for compressed files #6

Closed jaydrogers closed 6 years ago

jaydrogers commented 6 years ago

Thanks for putting this together @yboetz! Your work is amazing.

PREFACE: You know a lot more about bash than I do, so this is just a suggestion/question.

I saw at the bottom of the README that 50-fail2ban needed a configuration change in order for it to work (because of the compressed files).

Is it possible to use zgrep instead? This is able to search compressed files without any changes to the fail2ban configuration.

You can see in one of my commits, I just changed it in one location and it seems to have good results for me. If you test it out and like the results, then you can simply merge this pull request.

Thanks again for all of your work! Let me know if you have any questions.

yboetz commented 6 years ago

You're correct, you can use zgrep as you suggested. There was actually already a pull request for that feature :). But zgrep is slightly slower than grep, and I keep my logfiles uncompressed, that's why I want to keep using grep. And this repository is my personal source for these motd-scripts, so I'd like to keep grep here. But do keep it like this in your fork, it works and is the correct solution when your logfiles are compressed.