ybs32 / TweetMate-for-Android

will be updated irregularly.
Apache License 2.0
0 stars 0 forks source link

Some string constants are hard-coded in the java source #18

Closed ybs32 closed 2 years ago

ybs32 commented 3 years ago

What happened: Some string constants are hard-coded in the java source without using the string.xml resource definition.

ToastUtils.showLongToast("認証に成功しました!");

Acceptance criteria: All hard-coded string constants in the Java source are replaced with string.xml resource.


Note1: Do not concatenate text displayed with setText. Use resource string with placeholders. (ref: https://stackoverflow.com/questions/33164886/android-textview-do-not-concatenate-text-displayed-with-settext)

this.mRetweetedBy.setText(mStatus.getUser().getName() + " さんがリツイート");

Note2: Please consider I18n if it possible. This warning is currently ignored.

lintOptions {
    ~~~~~
    disable 'SetTextI18n'
    ~~~~~
}
ybs32 commented 2 years ago

Done