search

ybs32 / TweetMate-for-Android

will be updated irregularly.
Apache License 2.0
0 stars 0 forks source link

Improve/code review #85

Closed ybs32 closed 2 years ago

ybs96 commented 2 years ago

SonarQube analysis reported 50 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ActivityBase.java#L39: Define a constant instead of duplicating this literal "MainActivity" 3 times. rule
  2. CRITICAL ActivityBase.java#L40: Define a constant instead of duplicating this literal "SearchActivity" 3 times. rule
  3. CRITICAL TimelineActivity.java#L33: Define a constant instead of duplicating this literal "COLUMN_TYPE" 3 times. rule
  4. CRITICAL TimelineActivity.java#L34: Define a constant instead of duplicating this literal "STATUS" 3 times. rule
  5. CRITICAL TweetMateApp.java#L35: Make the enclosing method "static" or remove this set. rule
  6. CRITICAL NoticeDialog.java#L25: Define a constant instead of duplicating this literal "DESCRIPTION" 3 times. rule
  7. CRITICAL TweetDialog.java#L169: Refactor this method to reduce its Cognitive Complexity from 38 to the 15 allowed. rule
  8. CRITICAL TweetClickListener.java#L38: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule
  9. CRITICAL ClickUseCase.java#L135: Define a constant instead of duplicating this literal "https://twitter.com/" 3 times. rule
  10. CRITICAL DownloadUseCase.java#L71: Change this "try" to a try-with-resources. (sonar.java.source not set. Assuming 7 or greater.) rule