Review & Commit window: successful commit feedback

ycaihua / svnx

Automatically exported from code.google.com/p/svnx

1 stars 0 forks source link

Review & Commit window: successful commit feedback #86

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Open Working copy
2. Select Review
3. Select Recent
4. Select some revision
5. Commit changes

What is the expected output? What do you see instead?

The review window should be closed once commited

What version of the product are you using? On what operating system?
svnx 1.2b1, snow leopard.

Please provide any additional information below.

Original issue reported on code.google.com by ram...@gmail.com on 26 Apr 2010 at 1:26

GoogleCodeExporter commented 9 years ago

Or perhaps may need some kind of notification that commit has been successful

Original comment by ram...@gmail.com on 26 Apr 2010 at 1:36

GoogleCodeExporter commented 9 years ago

The Review & Commit window is supposed to remain open - very useful for further 
commits.
The detailed commit progress/output can be viewed in the Working Copy's output 
drawer.
The committed items are removed from the list ONLY on success.
On failure an alert is displayed.

I think it would be bad to close the window or interrupt the user to tell them 
"everything is OK".
However, it would probably be possible to display a message in the diff pane
along the lines of "X items successfully committed as revision R".

Original comment by chris...@gmail.com on 26 Apr 2010 at 2:15

Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

I see, is that at least possible to add a spinning icon to let the user know 
that it is in progress, what happens is 
that the close icon is in edit state, and there is no graphical representation 
that something is happening after 
you pressed commit, in my case the server is quite far so it always takes a 
good 30 seconds at least to commit.

Original comment by ram...@gmail.com on 26 Apr 2010 at 4:52

GoogleCodeExporter commented 9 years ago

There is already a progress indicator (that appears) right next to the Commit 
button.
The window's close button should also loose its (document edited) dot once the 
commit completes.
And finally the Working Copy window refreshes after the commit.

Open the Working Copy's output drawer or Activity window for detailed progress 
info.

Original comment by chris...@gmail.com on 26 Apr 2010 at 5:32

GoogleCodeExporter commented 9 years ago

hmm, interesting i didn't see anything, will double check and come back. Thanks.

Original comment by ram...@gmail.com on 26 Apr 2010 at 7:56

GoogleCodeExporter commented 9 years ago

Yup, i can now see the progress indicator, my bad! thanks Chris!

Original comment by ram...@gmail.com on 28 Apr 2010 at 10:15

GoogleCodeExporter commented 9 years ago

OK.

I'm going to change this to a feature/enhancement request to:
On a successful commit via a Review & Commit window, display
"X items successfully committed as revision R" in the diff pane.

Thanks for your all feedback Ramzez.

Original comment by chris...@gmail.com on 28 Apr 2010 at 3:42

Changed title: Review & Commit window: successful commit feedback

GoogleCodeExporter commented 9 years ago

That would be excellent!

Original comment by ram...@gmail.com on 28 Apr 2010 at 3:45

GoogleCodeExporter commented 9 years ago

Added in 1.3b1.

Original comment by chris...@gmail.com on 16 Sep 2010 at 12:13

Changed state: Done