photos alt tags and title tag for lightboxes

[ycb]

or are we using pretty photo as per line #113 of functions.php?

[highvoltag3]

We are using pretyphoto since it's more flexible than thinkbox, no need to change the class="thickbox" actually my part here is done, the alt tag for every photo needs to be something meaningful and the title needs to be present (since this will be picked up for the description) Bouncing this ticket back to you (since I got no idea what the title and alt tag should be for each).

[ycb]

Will assign this to Kwan once he gets a github account...

[ycb]

actually we have a couple issues here:

1. if no alt or title is used then the space for those should not appear. there was no requirement or indication that a title and description is needed for every image.
2. the expand button looks like a close button. and it resides top right where the close button normally is found. close button must be top right. if you want to keep the expand button (which is nice but optional IMO) we need a new button and a better location.

[highvoltag3]

Will respond to this tomorrow to much discussions for one day :p two words though OSX…

Though I didn't make that or place it there's it's prettybox defaults.

Cheers,

---

MFA. Darío J. Novoa V. Web Developer & Designer www.darionovoa.info

On Jun 3, 2013, at 7:50 PM, ycb notifications@github.com wrote:

actually we have a couple issues here:

if no alt or title is used then the space for those should not appear. there was no requirement or indication that a title and description is needed for every image.

the expand button looks like a close button. and it resides top right where the close button normally is found. close button must be top right. if you want to keep the expand button (which is nice but optional IMO) we need a new button and a better location.

— Reply to this email directly or view it on GitHub.

[highvoltag3]

About 1) Alt and Title should always be specified, it's S.E.O 101, I understand that it shouldn't be a requirement for the lightbox, and it is not. Simply if there's none of those it won't show a title and the description will say undefined since it is not defined.

2) As I said on my prev. comment, that's how prettyphoto comes out of the box, I don't think having a close button always on the right is a pattern today (at least not any more) with so many people moving to tablets and also OSX gaining so much traction the top right corner means expand (fullscreen now). I do understand that this is a really huge point of debate and that old habits are still widely present among users.

But for what it's worth I think this is a minor thing, it's a lightbox users create habits of usage if the expand trying to close it once they will get to know this one (learn) and click pout of it, we can also go ahead and just make it a close button, but from my experience this was not a problem it was really intuitive when I tried it and I had never used prettyphoto before in fact I wasn't even aware of this until you brought it up.

Again on this one we can just default to the norm if need be, I'm not defending anything I'm just say'

[ycb]

I get it and agree in many ways. But description "undefined" is not an acceptable solution for this project. And for this audience we need more understandable controls.

Please see about solutions for these two issues. And as always, thanks!

On Jun 4, 2013, at 9:15 AM, "Dario J Novoa V." notifications@github.com wrote:

About 1) Alt and Title should always be specified, it's S.E.O 101, I understand that it shouldn't be a requirement for the lightbox, and it is not. Simply if there's none of those it won't show a title and the description will say undefined since it is not defined.

2) As I said on my prev. comment, that's how prettyphoto comes out of the box, I don't think having a close button always on the right is a pattern today (at least not any more) with so many people moving to tablets and also OSX gaining so much traction the top right corner means expand (fullscreen now). I do understand that this is a really huge point of debate and that old habits are still widely present among users.

But for what it's worth I think this is a minor thing, it's a lightbox users create habits of usage if the expand trying to close it once they will get to know this one (learn) and click pout of it, we can also go ahead and just make it a close button, but from my experience this was not a problem it was really intuitive when I tried it and I had never used prettyphoto before in fact I wasn't even aware of this until you brought it up.

Again on this one we can just default to the norm if need be, I'm not defending anything I'm just say'

— Reply to this email directly or view it on GitHub.

[highvoltag3]

• [x] Don't show description if title is not defined.
• [x] Change layout so there's no button on top and clearly mark that the X if to close the box.

[ycb]

still have an issue with native WP galleries and lightbox.

known defect: clicking on a thumbnail image loads a lightbox but not the image.

you had indicated this was a content entry defect - images links were incorrect. this does not seem to be the case:

expectation is that inserting a WP image gallery, clicking on thumbnails --> images load in a lightbox