search

ycba-cia / blacklight-collections2

5 stars 2 forks source link

Empty collection results necessary? #420

Closed edgartdata closed 1 year ago

edgartdata commented 1 year ago

All, following the "Referenced YCBA Works" in https://collections-test.britishart.yale.edu/catalog/orbis:583000 correctly returns all the P&S and P&D works illustrated or discussed in the book but the Collection facet also show 0 results for Archives, Frames, Rare Books and Reference Library. Do we want these null results to be displayed in the Collection facet?

image

flapka commented 1 year ago

No, I think null results should not be displayed -- to be consistent with how our facets display in other contexts.

For the fielded:ilsnumber search, null results appears in other facets too, e.g. Classification and Period.

image

image

edgartdata commented 1 year ago

Medium and Subject Terms as well so I think it might be something to reset overall/on all the facets.

yulgit1 commented 1 year ago

Fixed. Added facet.mincount=1 in solrconfig.xml in:

https://ciaindex.britishart.yale.edu/solr/#/~cores/ycba_blacklight_prod https://ciaindex.britishart.yale.edu/solr/#/~cores/ycba_blacklight

<requestHandler name="/query" class="solr.SearchHandler">
    <lst name="defaults">
      <str name="echoParams">explicit</str>
      <str name="wt">json</str>
      <str name="indent">true</str>
      <str name="facet.mincount">1</str>
    </lst>
  </requestHandler>