ycba-cia / blacklight-collections2

5 stars 2 forks source link

cds iiif redesign #56

Closed yulgit1 closed 3 years ago

yulgit1 commented 6 years ago

see #53 as well

yulgit1 commented 4 years ago

when cds2 is implemented remember to change ProcessHelper.getHeaders for image available/unavailable

edgartdata commented 3 years ago

@all: please add examples of records with lots of images and images of different kinds before the end of March.

edgartdata commented 3 years ago

https://collections.britishart.yale.edu/catalog/tms:722 has 16 images, many of them are conservation images.

flapka commented 3 years ago

From RBM:

edgartdata commented 3 years ago

Update from @yulgit1 on 3/26 at 4:34PM:

Activity stream https://ycba-cds-iiif.s3.amazonaws.com/jsonpages/collection1.json

Manifest URL scheme https://manifests.collections.yale.edu/ycba/orb/13065833 https://manifests.collections.yale.edu/ycba/obj/3776

json query in java: json.getJSONArray("items").getJSONObject(0).getJSONArray("thumbnail").getJSONObject(0).getString("id");

or as a json path:

items[0].thumbnail[0].id

It might be worth asking Seong if he’s tracking all the objects and using that rather than traversing the activity stream to get all the objects. Getting a solr dump of all the objects is another viable alternative.

edgartdata commented 3 years ago

At the 3/26 CIA & Friends meeting @yulgit1 reported that he had deployed Mirador 3 and CDS2 on our DEV server:

image

All, @BaylaArietta @flapka @EdwardTown1 @peeblesc @robl @KraigBinkowski @rchatalbash @mxgold (Melissa, feel free to share with imaging colleagues) @yhwang813 please test http://10.5.96.187:3000/ (needs VPN) and enter your comments/suggestions/questions/concerns about the look&feel and functionality of the viewer in this issue 56 by April 9.

Some feedback on Mirador 3 from the 3/26 meeting to Eric:

edgartdata commented 3 years ago

Some important dates:

annabozz commented 3 years ago

Distorted Image in Print Preview

example: http://10.5.96.187:3000/catalog/tms:34

This unframed, recto image is showing up as distorted during the print preview. Same problem happening to other images as well.

Showing up this way in Firefox, and in Google Chrome (testing via a Mac)

tms-34-firefox.pdf

annabozz commented 3 years ago

Image Keywords

example: http://10.5.96.187:3000/catalog/tms:8915

It appears that if there are NO image keywords assigned to an image in NetX, then the default text "Image from Yale University" appears for each image.

This also impacts the "Download/Print Selected Image" feature (image below).

Is it possible for the default to instead be blank? If it was blank would that mess up the usefullness of the drop down selection shown below- does every image need at least one keyword? (@mxgold to be looped in on final decision)

Showing up this way in Firefox, and in Google Chrome (testing via a Mac)

Screen Shot 2021-04-06 at 11 52 57 AM

yulgit1 commented 3 years ago

@clemgreen Could not recreate distorted print image (Mac/safari, chrome,FF)

The default image captions "Image from Yale University" seem to come from CDS2. If we agree to a change it should be requested here: https://git.yale.edu/cultural-heritage-dam/cds2-project/issues

flapka commented 3 years ago

RBM agrees with @clemgreen 's preference for the caption to appear as blank rather than "Image from Yale University" when the data is absent. We will in time fill in those blanks, but that won't happen overnight.

As for the source of the data, is it not the NetX "Image Caption" field, instead of the NetX "Image Keywords" field? This appears to be the case with RBM images at least.

yulgit1 commented 3 years ago

@flapka yes imagecaption not imagekeywords appears to be what is pushed into the manifest label.

bobhixon commented 3 years ago

@yulgit1 The distorted print images happened for me and Melissa as well.

flapka commented 3 years ago

In general, RBM is thrilled with the new iiif implementation with RBM collections. The handful of recommendations that follow are suggested as incremental (sometimes subjective) improvements. It's possible that some of these "issues" are inflexibly baked in to the Mirador 3 viewer.

  1. As noted in our previous meeting, the semi-transparent band at the bottom of the image area is undesirable, as it obscures a portion of the image. If there's a way to remove it, that'd be great.
  2. The metadata area (opened via the hamburger menu at top left) is rather narrow. Could it be slightly wider? Or could the width respond to user adjustments?
  3. Is it possible to adjust the typography for the metadata area. The fluctuations in point size seem mildly wonky, and at times I wish there was a clearer distinction (via typography) between field label and field data.
  4. I wonder if it will be at all confusing to users that the default viewer in our object display differs (in mild ways) from the viewer that opens upon clicking the iiif icon.
  5. Background color is a major difference between these two viewers. I prefer the black/dark gray in the latter. It seems calmer.
  6. Once a user clicks on the "Window views & thumbnail display" (second from top right) there seems to be no way to exit the menu without selecting a change. It'd be nice if there was a way to simply escape, without selecting a change.
flapka commented 3 years ago
  1. The thumbnail band at bottom at times does not stretch all the way across the view (prematurely and abruptly cut off). See screenshot. image
robl commented 3 years ago

This is really getting close! As an addendum to Francis’s comments, with which I agree, three thoughts:

Of course the two “hover” ideas above would only work in some interaction contexts (e.g., not on touch), but may still help.

yulgit1 commented 3 years ago

Answering above comments @flapka (1):

I think that is there so the controls resolve again the background. If you want to see the bottom of the image un-obscured you can always drag the image up. But submitted a ticket:

https://github.com/ProjectMirador/mirador/issues/3407

yulgit1 commented 3 years ago

Answering above comments @flapka (2): Answering above comments @flapka (3):

Submitted a ticket:

https://github.com/ProjectMirador/mirador/issues/3408

yulgit1 commented 3 years ago

Answering above comments @flapka (4):

I would hope the user understands. Why offer the embedded/standalone option if they were exactly the same. What could be done to make the difference more intuitive?

Answering above comments @flapka (5):

Light/dark is configurable. What do people prefer? FWIW I like light, seems cleaner.

Screen Shot 2021-04-07 at 4 20 18 PM

Screen Shot 2021-04-07 at 4 20 55 PM

yulgit1 commented 3 years ago

Answering above comments @flapka (6) & @robl (bullet1)

Pressing escape seems to do the trick but that is counterintituive and you may expect to be able to do this by clicking on something. Submitted a ticket.

https://github.com/ProjectMirador/mirador/issues/3410

yulgit1 commented 3 years ago

Answering above comments @flapka (7): This might have been something transient (could not recreate (on Mac: chrome, firefox, or safari)

yulgit1 commented 3 years ago

Answering above comments @robl (bullet2)

Submitted a ticket: https://github.com/ProjectMirador/mirador/issues/3409

Answering above comments @robl (bullet3) "...How about adding on-hover text for the IIIF icon, to say “View image in full IIIF viewer” or something like that?" Will do.

mxgold commented 3 years ago

Observation: hi-res tiff downloads receive a generic filename: "source.tif"

robl commented 3 years ago

Important catch, @mxgold .

yulgit1 commented 3 years ago

https://git.yale.edu/cultural-heritage-dam/cds2-project/issues/23

edgartdata commented 3 years ago

Meeting notes from 4/9: (@flapka @peeblesc @rchatalbash please be in touch/comment here if you have questions or concerns)

Other elements we did not have time to discuss:

I agree with @flapka on this last point. This goes back to the necessity to craft a short video tutorial I think. When I escape I get this error message in Chrome: Mirador 3 gallery view bug in Chrome

I found a way to add several IIIF manifests to Mirador 3 but not to see them in a gallery viewing mode...yet. Anyone? Mirador 3 add resource

robl commented 3 years ago

@edgartdata , re: your idea that "@robl if you are going to contact the Mirador Slack channel, I wonder if we should 'bundle' our questions?" is intriguing. My first instinct was yes, but then I realized that each question might spawn its own focused comment thread; so I'm thinking separate may be best for clarity. I could plan to post the overlay question this afternoon and note that it may be the first of several from us, and then you might post more there, if that sounds good?

edgartdata commented 3 years ago

@robl that makes sense. Thanks Rob!

robl commented 3 years ago

Overlay question asked: https://iiif.slack.com/archives/C148SMLD7/p1618002220068500

mxgold commented 3 years ago

Please take a quick moment to vote for or suggest your preferred boilerplate text alternative for the null image captions using this Google form. Poll will close Monday at 2 pm-ish. thanks! https://docs.google.com/forms/d/e/1FAIpQLSfXMitbUw6tdlwoTTlM5dH13hkEJ0l272kvRyMOJ95A8Hd59A/viewform?usp=sf_link

robl commented 3 years ago

A reply via Slack regarding the navigation overlay:

Hello Mirador experts, The Yale Center for British Art has a new iteration of online collection search about to launch, and we are moving to Mirador 3 for it. A lingering design concern with our embedded viewer is the presence of the translucent overlay bar of image-navigation icons across the bottom of the image. Does anyone know of a way to relocate that nav bar to sit cleanly below the image instead? Thanks, and apologies if this is a naïve config question!

ggeisler 6:10 PM Hi @rob.lancefield. I don’t believe there is an easy configuration setting to relocate the bottom navbar, though I understand why you might want to. You might take a look at the customization the Art Institute of Chicago did for some ideas. I think they customized more details than simply relocating the navbar, but perhaps their plugin (which I believe was aimed at providing users with a more simplified UI) will give you some ideas: https://github.com/art-institute-of-chicago/aic-mirador-ui

PS: If useful, I (Rob) could provide an introduction to a software engineer at the AIC.

robl commented 3 years ago

And more, from Tina Shah at the AIC:

rob, yes, we created plugins to remove, move and replace the UI with our own graphics. not sure if you’ve already checked it out, but here are main plugin files we used for the nav:

  1. Remove nav: https://github.com/art-institute-of-chicago/aic-mirador-ui/blob/master/src/plugins/aicRemoveNavPlugin.js
  2. Change zoom button icons, styles, behavior and placement https://github.com/art-institute-of-chicago/aic-mirador-ui/blob/master/src/plugins/aicZoomButtonsPlugin.js
  3. Same as above with nav buttons: https://github.com/art-institute-of-chicago/aic-mirador-ui/blob/master/src/plugins/aicNavigationButtonsPlugin.js
mxgold commented 3 years ago

boilerplate text alternative for the null image captions for the art collections will be "Image Courtesy YCBA" - this will replace the CDS2 boilerplate "Image from Yale University" @bobhixon & @mxgold will follow up on bulk update(s) in NetX.

edgartdata commented 3 years ago

Thanks for letting us know @mxgold

yulgit1 commented 3 years ago

question to mirador slack channel:

"https://collections-test.britishart.yale.edu/catalog/tms:10034 https://collections.britishart.yale.edu/catalog/tms:10034 Hoping there a simple.answer. On collections-test above, the IIIF icon no longer drags in safari (FF, chrome OK), even with draggable attribute. Collections (the current) is OK. The only changes as adding the title and draggable attributes, and a different mirador viewer. But even with these the same between collections-test and collections, the icon won’t drag in safari anymore with collections-test."

yulgit1 commented 3 years ago

Ticket to mirador:

https://github.com/ProjectMirador/mirador/issues/3425

edgartdata commented 3 years ago

Closing this issue since CDS2 and Mirador 3 have been deployed and opening #300 for Mirador 3 only related questions/issues.