yccheok / jstock

JStock is a free stock market software for 28 countries.
https://jstock.org
660 stars 347 forks source link

latest code not build even after putting jstock.jar #111

Closed anujrathi26 closed 4 years ago

anujrathi26 commented 6 years ago

These are not found in latest code even after putting jstock.jar 1.org.yccheok.jstock.engine.Utils.clearGoogleCodeDatabaseCache();

  1. org.yccheok.jstock.engine.Utils.isGoogleCodeDatabaseRequired(country)
  2. GoogleCodeDatabaseRunnable(country) 32855599-2a97b472-ca68-11e7-8316-b8cad1853dd7
yccheok commented 6 years ago

Due to complicated legal issue, we decides not to release certain code block.

We should release some binary library, to make the source code build-able.

However, we are pretty much busy with other higher priority thing. Hence, we don't have an estimated timeline on when the binary library will be available.

rkraneis commented 4 years ago

Any news here, @yccheok ? Also, you may want to change the claim It's free and open source on the homepage. In the current state it's not. I only found out by using git bisect and ending up at

8df5fb6886b5d1f493b84b6fcf7bdf3a276da3d4 is the first bad commit commit 8df5fb6886b5d1f493b84b6fcf7bdf3a276da3d4 Author: Yan Cheng Cheok yccheok@yahoo.com Date: Sat Jul 25 22:44:29 2015 +0800

org.yccheok.jstock.engine will be closed source component.

rkraneis commented 4 years ago

(And don't get me wrong: your code, your rules ;-) But having GPL V2 in docs and as file headers kind of sends the wrong signal to possible contributors)

yccheok commented 4 years ago

I just remove the open source wording - https://github.com/yccheok/yccheok.github.io/commit/de57039926554610d592bd4b753ea2afebb96cde

I also updated README with wording

JStock is NOT a fully open source project. Some of the code components are closed source. You will NOT able to compile JStock even after downloading source code from here.