yccheok / jstock

JStock is a free stock market software for 28 countries.
https://jstock.org
663 stars 347 forks source link

Logging is hard-coded to disabled #140

Open fallenguru opened 5 years ago

fallenguru commented 5 years ago

In theory, it should be possible to enable (and configure) logging via editing config/commons-logging.properties. In practice, a dummy/no-op logger is hard-coded in jstock/src/org/yccheok/jstock/gui/JStock.java: "static { System.setProperty("org.apache.commons.logging.Log", "org.apache.commons.logging.impl.NoOpLog"); }", which overrides any run-time configuration.

Please comment out this line again in future releases, so that the default no-op logging can be changed, if desired.

oehm-smith commented 4 years ago

Agreed