search

yccheok / jstock

JStock is a free stock market software for 28 countries.
https://jstock.org
657 stars 345 forks source link

JRE and other run-time requirements should be documented (and ideally be relaxed) #141

Closed fallenguru closed 4 years ago

fallenguru commented 4 years ago

JStock seems to be quite sensitive to the installed Java version and/or additional non-standard components. As in, if everything isn't just right, certain functionality will silently(!) fail.

On Ubuntu 18.04.3, the package libcanberra-gtk-module is required to get rid of a (harmless) error message.

I don't mind the fact that JStock depends on specific pieces of software in particular versions being present, but I would like to know what they are; ideally to see error messages, when they aren't met. Currently the install help just says to "install Java". Regardless, things should never silently just not work.

I don't know if JStock can be updated to run on any modern Java implementation, but as long as there are more specific requirements, it'd be great if they could be explicitly stated.

yccheok commented 4 years ago

Sorry. I still have no idea why JStock yields different behavior in different Java vendor platform. I need to spend some time to figure out the real root cause. Thanks for reporting this.

yccheok commented 4 years ago

@fallenguru

I have fixed the problem, with instruction on how to install Java right here : https://jstock.org/help_install_upgrade.html#install-linux

Now, JStock should be able to run under openjdk 11. Can you kindly try it out with latest JStock release, and let us know the outcome? Thank you.

fallenguru commented 4 years ago

I haven't done any extensive testing by any means, but jstock-1.0.7.41 launches and seems to run fine using Ubuntu 18.04.3's default-jre (currently openjdk-11-jre). Thank you!

On startup, I get a couple of warnings, but they seem to be benign: Warning: /bin/java does not exist WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.thoughtworks.xstream.core.util.Fields (file:/home/chris/local/jstock-new/jstock/lib/xstream-1.4.11.1.jar) to field java.util.TreeMap.comparator WARNING: Please consider reporting this to the maintainers of com.thoughtworks.xstream.core.util.Fields WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release Security framework of XStream not initialized, XStream is probably vulnerable. [... last one repeated a few times ...]

I have a few suggestions to further improve the documentation at https://jstock.org/help_install_upgrade.html#install-linux:

yccheok commented 4 years ago

Thank you. I had revised accordingly - https://jstock.org/help_install_upgrade.html#install-linux

Does it look good to you now?

fallenguru commented 4 years ago

Brilliant, thank you!

ghost commented 1 year ago

I think this issue is still present.

I can run JStock with Java 11, but it does not actually work expected way. E.g. the prices in the table are all displayed as 0.

Reopen?

yccheok commented 1 year ago

Please make sure you are using the latest JStock. If not, let me know.

In the near coming months, we will package JStock together with Java 17, so that it will be less hassle for the users.

On Mon, 5 Jun 2023 at 17:04, Lockywolf @.***> wrote:

I think this issue is still present.

I can run JStock with Java 11, but it does not actually work expected way. E.g. the prices in the table are all displayed as 0.

Reopen?

— Reply to this email directly, view it on GitHub https://github.com/yccheok/jstock/issues/141#issuecomment-1576412173, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACLINBR64URLE5SJSNQWELXJWOI7ANCNFSM4I54MSWA . You are receiving this because you commented.Message ID: @.***>

-- Thanks and Regards Yan Cheng Cheok