yccheok / jstock

JStock is a free stock market software for 28 countries.
https://jstock.org
660 stars 347 forks source link

File menubar is broken if you dismiss Google auth dialog #92

Closed javabrett closed 7 years ago

javabrett commented 7 years ago
  1. File -> Open from Cloud.
  2. Dismiss that dialog.
  3. Notice that the File menu is now not selectable.
shuwnyuantee commented 7 years ago

Hi @javabrett , I am a developer from JStock team. May I know which OS you are running on?

javabrett commented 7 years ago

Linux Ubuntu running gnome. I don't have the exact version I was running at the time.

shuwnyuantee commented 7 years ago

Hi Bret,

I see. How about now, if you try running latest JStock with your current environment? Thanks.

On Sun, Apr 2, 2017 at 6:48 PM, Brett Randall notifications@github.com wrote:

Linux Ubuntu running gnome. I don't have the exact version I was running at the time.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/yccheok/jstock/issues/92#issuecomment-290978531, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlf7iqV8zE4vrhmsuWmj6Xjh8dRvP2Oks5rr30UgaJpZM4ME7Ts .

javabrett commented 7 years ago

Same behaviour in 1.0.7.21. To see the problem, you need to dismiss the Cloud login dialog using the window close handle. Note that the File menu is disabled when this dialog is raised - looks like there must be a missing listener to re-enable it.

This was found due to #86 when the Cloud login doesn't load at all due to no proxy being configured.

javabrett commented 7 years ago

Hmmm just started working for me on 1.0.7.21. Not sure what happened with the first test. Looks like this is fixed, thanks.