yck1509 / ConfuserEx

An open-source, free protector for .NET applications
http://yck1509.github.io/ConfuserEx/
Other
3.57k stars 1.64k forks source link

Public properties in internal classes are renamed #533

Open SoSuDresden opened 8 years ago

SoSuDresden commented 8 years ago

If a public property is in a internal class, so that property will be renamed. I think that is not right.

SlowLogicBoy commented 8 years ago

Why do you think that is not right? Internal classes are not accessable by outside assemblies (without reflection) so that means that it's safe to rename public properties in internal classes. That might be a problem if you are accessing these properties using reflection with hardcoded string. For example.: o.GetType().GetProperty("Property").GetValue(o, null);

SoSuDresden commented 8 years ago

For example, in small dialogs there I have internal classes (XAML-Dialog) with public properties, which I bind internal in the XAML code of the same class. The same is with classes they used for binding (only internal datatypes for list etc.). If I put this classes in internal classes, is the binding not possible (internal class X{ public class Y {...}...}).

I switched from Eazfuscator to ConfuserEx and have now with the same code more problems by renaming.