ycm-core / lsp-examples

Use any language server with YouCompleteMe.
https://ycm-core.github.io/YouCompleteMe
Apache License 2.0
82 stars 26 forks source link

add notice of ycm_extra_conf place for kotlin server setup #6

Closed Jackey-Huo closed 5 years ago

Jackey-Huo commented 5 years ago

PR for issue #5


This change is Reviewable

bstaletic commented 5 years ago

Thanks for the PR. The trouble you encountered could, and probably will, happen to someone else who decides to try some other server, depending on how sensitive the server is to correct rootUri. For that reason, I think it's better to have this notice in the common part of the README and reference it from the Kotlin section.

Under "Known Issues" there's one mentioning Kotlin, which isn't valid any more. May I ask you to remove it from the README?

Jackey-Huo commented 5 years ago

Got it. I have moved the warning into the common part and reference it in kotlin section.

And the expired Known Issue was removed.

Jackey-Huo commented 5 years ago

I applied the advice. But after a little test, I found open vim in project root doest not work, so have a tiny change in 2nd suggestion.

Jackey-Huo commented 5 years ago

link changed