Closed sankhesh closed 8 months ago
Thanks for the pull request.
While I am not at all against this, I would like to know what -prerelease
does.
Apologies, but I do not have a Windows machine handy.
With -prerelease
, vswhere
also returns any prereleases/preview versions along with the release versions.
See doc: https://github.com/microsoft/vswhere/blob/f791b32483204ad3b0ff3cdce57a0c85ee119a8f/src/vswhere.lib/vswhere.lib.rc#L80
The current code defaults to the latest without user opt-in/choice if there are multiple versions. This change just extends it further to allow latest Preview versions as well. Note that without this change, if I just have VS Preview version installed (with valid MSVC compiler), ycmd build fails with the error that MSVC could not be found.
With
-prerelease
,vswhere
also returns any prereleases/preview versions along with the release versions.The current code defaults to the latest without user opt-in/choice if there are multiple versions. This change just extends it further to allow latest Preview versions as well. Note that without this change, if I just have VS Preview version installed (with valid MSVC compiler), ycmd build fails with the error that MSVC could not be found.
If I have both a released and pre-release version, which is picked?
If I have both a released and pre-release version, which is picked?
I am not an expert but IMHO, because of the -latest
flag, the later of the two versions will be picked i.e. between VS2019 Preview and VS 2022, the latter will be chosen.
Flake8 error means ci is broken. Line too long.
Thanks, I'll fix that.
Hmm.. I don't know why that CI is failing.
It happens. Windows jobs are a little flakey.
Merging #1711 (aba1b1d) into master (e755af6) will decrease coverage by
0.01%
. Report is 16 commits behind head on master. The diff coverage isn/a
.
@bstaletic @puremourning Good to merge?
I am ok with this pull request, but @puremourning said he would prefer this to be opt-in.
I’m happy to make it work by chance or by opt-in, but not by default.
So could you add an option like --preview-msvc
(or smothing, naming is hard) to the argument parser in build.py
?
@bstaletic @puremourning The latest commit adds the --preview-msvc
option.
Thanks for sending a PR!
Thanks for sending a PR!
@bstaletic @puremourning Anything else needed here?
@bstaletic @puremourning Anything else needed here?
Well, CI is failing, so we will need to resolve that before merging.
Thanks for sending a PR!
This change allows compiling ycmd against latest Visual Studio Preview versions.
Tested against Visual Studio 2022 Community version 17.8.0 Preview 2.0.
This change is![Reviewable](https://reviewable.io/review_button.svg)