search

ycm-core / ycmd

A code-completion & code-comprehension server
https://ycm-core.github.io/ycmd/
GNU General Public License v3.0
1.69k stars 764 forks source link

Useful pylint fixes #1715

Open bstaletic opened 11 months ago

bstaletic commented 11 months ago

After combing through all the stuff pylint has found, this seems to me the useful part.

The only questionable thing here, I think, could be the stuff related to open() and explicit encoding argument. This changes behaviour! Without specifying, the encoding is platform dependent. See https://docs.python.org/3/library/functions.html#open for details.

Fixes #1672

The dead code in python completer (see #1672) is removed in this pull request.

This change is Reviewable

codecov[bot] commented 11 months ago

Codecov Report

Merging #1715 (376fba1) into master (adce5d8) will increase coverage by 0.47%. The diff coverage is 61.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1715 +/- ## ========================================== + Coverage 94.93% 95.40% +0.47% ========================================== Files 51 83 +32 Lines 6657 8123 +1466 Branches 0 165 +165 ========================================== + Hits 6320 7750 +1430 + Misses 337 322 -15 - Partials 0 51 +51 ```